Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 171055: Fix crash that could happen on shutdown if the ResourceMessageFilter tried to... (Closed)

Created:
11 years, 4 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Paul Godavari
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Fix crash that could happen on shutdown if the ResourceMessageFilter tried to get the IO thread's message loop when it was going away. Do the same acrobatics as in BufferedResourceHandler by going to the UI thread first, and doing refcounting manually. Also fix an issue I saw by inspection in BufferedResourceHandler, where Release should be called at the end of the function. BUG=19415 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23563

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -23 lines) Patch
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 2 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 3 chunks +34 lines, -10 lines 0 comments Download
M chrome/test/data/reliability/known_crashes.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
11 years, 4 months ago (2009-08-17 18:24:15 UTC) #1
Paul Godavari
http://codereview.chromium.org/171055/diff/1004/10 File chrome/browser/renderer_host/buffered_resource_handler.cc (right): http://codereview.chromium.org/171055/diff/1004/10#newcode429 Line 429: if (!request_) Need to Release() here as well, ...
11 years, 4 months ago (2009-08-17 18:34:42 UTC) #2
jam
http://codereview.chromium.org/171055/diff/1004/10 File chrome/browser/renderer_host/buffered_resource_handler.cc (right): http://codereview.chromium.org/171055/diff/1004/10#newcode429 Line 429: if (!request_) On 2009/08/17 18:34:42, Paul Godavari wrote: ...
11 years, 4 months ago (2009-08-17 18:36:39 UTC) #3
Paul Godavari
11 years, 4 months ago (2009-08-17 18:37:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698