media: Support MojoAudioDecoder.

media: Support MojoAudioDecoder.

Details:
- Support mojo audio decoder in gn args.
- Add DecoderFactory to help create external decoders.
- Add MojoDecoderFactory that can create MojoAudioDecoder.
- When mojo audio decoder is enabled, enable MojoDecoderFactory.

In the next CL we'll add mojo audio decoder interface and services.
We'll also add real implementation of MojoAudioDecoder.

To test this on Desktop, set the following gn arguments:

enable_mojo_media = true
mojo_media_services = [ "audio_decoder" ]

Then in DecoderSelector, manually disable DecryptingAudioDecoder and
DecryptingDemuxerStream. Now try to play an encrypted audio,
MojoAudioDecoder should be selected. But it'll fail immediately in the
first Decode() call.

BUG=542910
TEST=See above.

Committed: https://crrev.com/409e5355ae1269cde51dc5b73b4592bad4e8c2ea
Cr-Commit-Position: refs/heads/master@{#376878}

[xhwang, 2016-02-20 07:39:48]

rebase only

[xhwang, 2016-02-20 07:40:33]

Patchset #1 (id:1) has been deleted

[xhwang, 2016-02-20 07:44:05]

[email protected] changed reviewers:
+ [email protected]

[xhwang, 2016-02-20 07:44:05]

dalecurtis: PTAL
timav: FYI

[DaleCurtis, 2016-02-22 19:20:49]

lgtm

https://codereview.chromium.org/1717933002/diff/40001/media/media_options.gni
File media/media_options.gni (right):

https://codereview.chromium.org/1717933002/diff/40001/media/media_options.gni...
media/media_options.gni:91: #                    Renderer. Cannot be used with
the mojo Renderer above.
In the future we may want both renderer + audio decoder separately so that we
can host MediaPlayer in a mojo renderer.

https://codereview.chromium.org/1717933002/diff/40001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder.h (right):

https://codereview.chromium.org/1717933002/diff/40001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder.h:22: ~MojoAudioDecoder() final;
Do we prefer final to override now?

[Tima Vaisburd, 2016-02-22 19:31:57]

[email protected] changed reviewers:
+ [email protected]

[Tima Vaisburd, 2016-02-22 19:31:57]

https://codereview.chromium.org/1717933002/diff/40001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder.h (right):

https://codereview.chromium.org/1717933002/diff/40001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder.h:33: bool NeedsBitstreamConversion()
const final;
NeedsBistreamConversion() is not pure virtual in the AudioDecoder and already
returns false. Or, are you preparing for the future as we know we will likely
need it?

[xhwang, 2016-02-22 22:33:07]

https://codereview.chromium.org/1717933002/diff/40001/media/media_options.gni
File media/media_options.gni (right):

https://codereview.chromium.org/1717933002/diff/40001/media/media_options.gni...
media/media_options.gni:91: #                    Renderer. Cannot be used with
the mojo Renderer above.
On 2016/02/22 19:20:48, DaleCurtis wrote:
> In the future we may want both renderer + audio decoder separately so that we
> can host MediaPlayer in a mojo renderer. 

Interesting use case. We'll see how things evolve ;)

https://codereview.chromium.org/1717933002/diff/40001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder.h (right):

https://codereview.chromium.org/1717933002/diff/40001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder.h:22: ~MojoAudioDecoder() final;
On 2016/02/22 19:20:48, DaleCurtis wrote:
> Do we prefer final to override now?

Both are allowed. Personally I like "final" more so that it can prevent people
to inherit from these classes which is usually a bad thing to do.

https://codereview.chromium.org/1717933002/diff/40001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder.h:33: bool NeedsBitstreamConversion()
const final;
On 2016/02/22 19:31:57, Tima Vaisburd wrote:
> NeedsBistreamConversion() is not pure virtual in the AudioDecoder and already
> returns false. Or, are you preparing for the future as we know we will likely
> need it?

Yeah, MojoAudioDecoder is just a transport layer. So it'll override all
functions and let the remote side decide what to do.

[xhwang, 2016-02-22 22:33:18]

The CQ bit was checked by [email protected]

[xhwang, 2016-02-22 22:33:20]

The CQ bit was unchecked by [email protected]

[xhwang, 2016-02-22 22:36:05]

jam: Please OWNERS review content/renderer/render_frame_impl.*

Sorry for adding more media stuff in this file :) I filed
https://bugs.chromium.org/p/chromium/issues/detail?id=588408 to track the work
of moving media stuff out of RenderFrameImpl. In mandoline we have a
MediaFactory to do media work for RFI. I think we can bring MediaFacotry back
and let it serve RFI as well.

[xhwang, 2016-02-22 22:36:39]

[email protected] changed reviewers:
+ [email protected]

[xhwang, 2016-02-22 22:36:39]

(oops, really add jam@ this time)

jam: Please OWNERS review content/renderer/render_frame_impl.*

Sorry for adding more media stuff in this file :) I filed
https://bugs.chromium.org/p/chromium/issues/detail?id=588408 to track the work
of moving media stuff out of RenderFrameImpl. In mandoline we have a
MediaFactory to do media work for RFI. I think we can bring MediaFacotry back
and let it serve RFI as well.

[jam, 2016-02-22 23:30:13]

lgtm

[xhwang, 2016-02-22 23:30:30]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-02-22 23:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717933002/40001

[commit-bot: I haz the power, 2016-02-23 00:52:51]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-02-23 00:55:01]

Description was changed from

==========
media: Support MojoAudioDecoder.

Details:
- Support mojo audio decoder in gn args.
- Add DecoderFactory to help create external decoders.
- Add MojoDecoderFactory that can create MojoAudioDecoder.
- When mojo audio decoder is enabled, enable MojoDecoderFactory.

In the next CL we'll add mojo audio decoder interface and services.
We'll also add real implementation of MojoAudioDecoder.

To test this on Desktop, set the following gn arguments:

enable_mojo_media = true
mojo_media_services = [ "audio_decoder" ]

Then in DecoderSelector, manually disable DecryptingAudioDecoder and
DecryptingDemuxerStream. Now try to play an encrypted audio,
MojoAudioDecoder should be selected. But it'll fail immediately in the
first Decode() call.

BUG=542910
TEST=See above.
==========

to

==========
media: Support MojoAudioDecoder.

Details:
- Support mojo audio decoder in gn args.
- Add DecoderFactory to help create external decoders.
- Add MojoDecoderFactory that can create MojoAudioDecoder.
- When mojo audio decoder is enabled, enable MojoDecoderFactory.

In the next CL we'll add mojo audio decoder interface and services.
We'll also add real implementation of MojoAudioDecoder.

To test this on Desktop, set the following gn arguments:

enable_mojo_media = true
mojo_media_services = [ "audio_decoder" ]

Then in DecoderSelector, manually disable DecryptingAudioDecoder and
DecryptingDemuxerStream. Now try to play an encrypted audio,
MojoAudioDecoder should be selected. But it'll fail immediately in the
first Decode() call.

BUG=542910
TEST=See above.

Committed: https://crrev.com/409e5355ae1269cde51dc5b73b4592bad4e8c2ea
Cr-Commit-Position: refs/heads/master@{#376878}
==========

[commit-bot: I haz the power, 2016-02-23 00:55:02]

Patchset 2 (id:??) landed as
https://crrev.com/409e5355ae1269cde51dc5b73b4592bad4e8c2ea
Cr-Commit-Position: refs/heads/master@{#376878}