c/b/ui: allow circular includes from c/b - WIP

c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595, 376000
TEST=see above
[email protected],[email protected],[email protected]

Committed: https://crrev.com/11b504b8632b2bd9ffb8e369a289f46a261a9647
Cr-Commit-Position: refs/heads/master@{#378803}

[tfarina, 2016-02-23 18:05:16]

Dirk, could you do a initial look in case Brett is busy?

I plan to send this to Scott (sky) if (when) I fix the following problem.

I now getting the following with the changes in this patch:

ERROR Dependency cycle:
  //chrome/browser:browser ->
  //chrome/browser/ui:ui ->
  //chrome/browser:browser

[Dirk Pranke, 2016-02-24 00:32:28]

lgtm, though obviously ideally we'd fix the cycle instead.

[tfarina, 2016-02-24 13:00:31]

On 2016/02/24 00:32:28, Dirk Pranke wrote:
> lgtm, though obviously ideally we'd fix the cycle instead.

Could you take another look? At patch set 1 'gn check' does not pass.
So, either we need to change something in gn (which will require a binary
release) or we still need to change something in the BUILD file to make it
happy (in case I'm missing something obvious).

[brettw, 2016-02-24 18:43:11]

You didn't give the error you saw, but it looks like you have a dependency cycle
between c/b and c/b/ui. The deps always have to be an acyclic graph. The
allow_circular_includes tells "gn check" to allow includes going against the
dependency graph.

In this case, c/b/ui would be unchanged and you would keep the change you made
in c/b. I think that should solve the problem (although there are likely to be
other "check" issues with this target).

[tfarina, 2016-02-24 18:51:25]

On 2016/02/24 18:43:11, brettw wrote:
> You didn't give the error you saw, but it looks like you have a dependency
cycle
> between c/b and c/b/ui.
In fact I did :)

https://codereview.chromium.org/1730643002/#msg1

ERROR Dependency cycle:
  //chrome/browser:browser ->
  //chrome/browser/ui:ui ->
  //chrome/browser:browser


> The deps always have to be an acyclic graph. The
> allow_circular_includes tells "gn check" to allow includes going against the
> dependency graph.
> 
> In this case, c/b/ui would be unchanged and you would keep the change you made
> in c/b. I think that should solve the problem (although there are likely to be
> other "check" issues with this target).
OK. Let me see that.

[tfarina, 2016-02-27 16:38:25]

Description was changed from

==========
c/b/ui: allow circular includes from c/b - WIP

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui/*

BUG=367595,376000
TEST=see above
[email protected],[email protected]
==========

to

==========
c/b/ui: allow circular includes from c/b - WIP

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected]
==========

[tfarina, 2016-02-27 16:41:54]

On 2016/02/24 18:43:11, brettw wrote: 
> In this case, c/b/ui would be unchanged and you would keep the change you made
> in c/b. I think that should solve the problem (although there are likely to be
> other "check" issues with this target).
You were right! And this triggered many, many errors.

Some like this:

ERROR at //chrome/browser/ui/views/translate/translate_icon_view.cc:8:11:
Include not allowed.
#include "chrome/app/chrome_command_ids.h"
          ^------------------------------
It is not in any dependency of
  //chrome/browser/ui:ui
The include file is in the target(s):
  //chrome/test:sync_performance_tests
  //chrome/test:sync_integration_tests
at least one of which should somehow be reachable.

There are also some //ash dependencies.

That I would like to address them in a follow up.

Brett, could you take another look? If possible, I would like to land this as is
and address the other errors as we go.

[brettw, 2016-02-29 22:06:17]

lgtm

https://codereview.chromium.org/1730643002/diff/60001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1730643002/diff/60001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:58: "//components/bookmarks/common",
Can you make this a public_dep of "//components/bookmark/browser" and delete it
from here?

https://codereview.chromium.org/1730643002/diff/60001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:84: "//components/omnibox/common",
Some as above (even though this common already existed).

[tfarina, 2016-03-02 15:32:40]

Description was changed from

==========
c/b/ui: allow circular includes from c/b - WIP

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected]
==========

to

==========
c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected]
==========

[tfarina, 2016-03-02 15:32:40]

[email protected] changed reviewers:
+ [email protected]

[tfarina, 2016-03-02 15:36:02]

Scott, could you approve this as well? Sending this to you as well, mostly
because you commeted on that thread in chromium-dev too.

https://codereview.chromium.org/1730643002/diff/60001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1730643002/diff/60001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:58: "//components/bookmarks/common",
On 2016/02/29 22:06:17, brettw wrote:
> Can you make this a public_dep of "//components/bookmark/browser" and delete
it
> from here?

Done.

https://codereview.chromium.org/1730643002/diff/60001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:84: "//components/omnibox/common",
On 2016/02/29 22:06:17, brettw wrote:
> Some as above (even though this common already existed).

Done.

[sky, 2016-03-02 18:32:43]

LGTM

[tfarina, 2016-03-02 19:42:33]

Description was changed from

==========
c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected]
==========

to

==========
c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected],[email protected]
==========

[tfarina, 2016-03-02 19:42:49]

The CQ bit was checked by [email protected]

[tfarina, 2016-03-02 19:42:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/1730643002/#ps80001
(title: "public_deps")

[commit-bot: I haz the power, 2016-03-02 19:43:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730643002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730643002/80001

[commit-bot: I haz the power, 2016-03-02 19:50:01]

Description was changed from

==========
c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected],[email protected]
==========

to

==========
c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected],[email protected]
==========

[commit-bot: I haz the power, 2016-03-02 19:50:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-02 19:51:20]

Description was changed from

==========
c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected],[email protected]
==========

to

==========
c/b/ui: allow circular includes from c/b

Tested on Linux with the following command line:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/browser/ui:ui

BUG=367595,376000
TEST=see above
[email protected],[email protected],[email protected]

Committed: https://crrev.com/11b504b8632b2bd9ffb8e369a289f46a261a9647
Cr-Commit-Position: refs/heads/master@{#378803}
==========

[commit-bot: I haz the power, 2016-03-02 19:51:21]

Patchset 5 (id:??) landed as
https://crrev.com/11b504b8632b2bd9ffb8e369a289f46a261a9647
Cr-Commit-Position: refs/heads/master@{#378803}