Issue 173622: share extension API test framework

Issue 173622: share extension API test framework (Closed)

Created:
11 years, 3 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, asargent_no_longer_on_chrome

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

share extension API test framework BUG=18442 TEST=ExtensionApiTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24892

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rebase #

Patch Set 4 : fixed a bad function call. added a missing file. added another try/catch. #

Total comments: 1

Patch Set 5 : unit test bug fix #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -333 lines)			Patch
M	chrome/browser/extensions/extension_test_api.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/common_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/extension_process_bindings.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/extensions/js_only_v8_extensions.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/js_only_v8_extensions.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/renderer_resources.grd	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
A	chrome/renderer/resources/extension_apitest.js	View		1 chunk	+120 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/bookmarks/api_test.js	View		1 chunk	+0 lines, -107 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/bookmarks/test.html	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/bookmarks/test.js	View	1	1 chunk	+16 lines, -16 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/override1/api_test.js	View		1 chunk	+0 lines, -107 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/override1/background.html	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/override1/downloads.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/override1/history.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/override1/newtab.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/override1/nonexistant.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/override1/test.js	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/storage/api_test.js	View		1 chunk	+0 lines, -77 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/storage/background.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/storage/tab.html	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	chrome/test/render_view_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

aa - v8 extension asargent - api changes

11 years, 3 months ago (2009-08-29 20:38:19 UTC) #1

asargent_no_longer_on_chrome

LGTM. Would it be worth making the api_test.js code conditionally included somehow, so it's only ...

11 years, 3 months ago (2009-08-29 23:27:57 UTC) #2

Aaron Boodman

11 years, 3 months ago (2009-08-30 02:32:49 UTC) #3

lgtm

http://codereview.chromium.org/173622/diff/1021/1030
File chrome/renderer/resources/extension_apitest.js (right):

http://codereview.chromium.org/173622/diff/1021/1030#newcode1
Line 1: // extension_apitest.js
Note: if you modify git-cl to pass -C to git-diff, this will show up as a
copy/modify in rietveld.

Expand Messages | Collapse Messages