Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 17395011: NaCl: Update revision in DEPS, r11569 -> r11573 (Closed)

Created:
7 years, 6 months ago by Mark Seaborn
Modified:
7 years, 6 months ago
CC:
chromium-reviews, halyavin, native-client-reviews_googlegroups.com, Vlad Shcherbina
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r11569 -> r11573, and remove two PNaCl tests This pulls in the following Native Client changes: r11570: (mseaborn) PNaCl: Remove use of link option "-Wn,--pnacl-nativeld=old" in tests r11571: (halyavin) Fix wrong calloc usage. r11572: (mseaborn) Update PNaCl toolchain revision to r11567: Enable ABI verifier in sandboxed translator r11573: (shcherbina) Add restricted registers handling to text-based specification. r11572 makes the PNaCl translator stricter so that it won't accept upstream LLVM's bitcode format or .ll assembly files. This affects two tests (bad2.pexe and pnacl_bad_pexe_undefined_syms) so that they produce the same error as the bad.pexe test, which is: pnacl_translator: pnacl.pexe: error: Invalid PNaCl bitcode header DoTranslate failed. [...:INFO:CONSOLE(0)] "NativeClient: NaCl module load failed: PnaclCoordinator: compile failed.", ... So remove those two tests because they now cover the same case as the bad.pexe test. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3469 TEST=NaCl/PNaCl tests in browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207460

Patch Set 1 #

Patch Set 2 : Remove some tests #

Patch Set 3 : Attempt to fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -99 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 1 2 1 chunk +2 lines, -25 lines 0 comments Download
D chrome/test/data/nacl/pnacl_error_handling/bad2.pexe View 1 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/data/nacl/pnacl_error_handling/pnacl_bad2_pexe.nmf View 1 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/nacl/pnacl_error_handling/pnacl_bad_pexe_undefined_syms.nmf View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/nacl/pnacl_error_handling/program_fragment.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Seaborn
7 years, 6 months ago (2013-06-19 18:24:10 UTC) #1
jvoung (off chromium)
LGTM thanks
7 years, 6 months ago (2013-06-19 18:27:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/17395011/28002
7 years, 6 months ago (2013-06-19 18:30:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=166360
7 years, 6 months ago (2013-06-20 07:29:27 UTC) #4
Mark Seaborn
7 years, 6 months ago (2013-06-20 17:03:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r207460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698