Make ProcessSingletonLinux check the hostname to avoid multiple uses of a profile over NFS.

Make ProcessSingletonLinux check the hostname to avoid multiple uses of a profile over NFS.

In order to avoid the singleton socket filename from exceeding the max socket name length, the socket is just named "SingletonSocket" and a new file "SingletonLock" is used for the hostname&pid.

BUG=17549
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23930

[willchan no longer on Chromium, 2009-08-19 18:12:24]

LGTM.  You might want to try running in valgrind using chrome_tests.sh or
whatever the build bots use, because suzhe was running into valgrind issues when
he made his last change here.  Thanks for the fix.

http://codereview.chromium.org/174041/diff/1/5
File chrome/browser/process_singleton_linux.cc (right):

http://codereview.chromium.org/174041/diff/1/5#newcode12
Line 12: // The destination is a string containing the hostname and process id
of chrome's
Exceeds 80 columns

http://codereview.chromium.org/174041/diff/1/5#newcode42
Line 42: #include <cstdio>
We don't use stdio, we use LOG.

http://codereview.chromium.org/174041/diff/1/5#newcode223
Line 223: // Unlink a socket path. If the path is a symbol link, then the symbol
link
You should update this comment, since it's not strictly a socket path now. 
Also, s/symbol/symbolic/ while you're there.

http://codereview.chromium.org/174041/diff/1/5#newcode235
Line 235: std::string* hostname,
indentation is off

[mattm, 2009-08-19 20:53:27]

It seems to fail for me under valgrind even with the trunk version :(

There appears to be some sort of inter-test interaction, if I run each test
alone they work.  Gonna have to dig into it some more.

On 2009/08/19 18:12:24, willchan wrote:
> LGTM.  You might want to try running in valgrind using chrome_tests.sh or
> whatever the build bots use, because suzhe was running into valgrind issues
when
> he made his last change here.  Thanks for the fix.
> 
> http://codereview.chromium.org/174041/diff/1/5
> File chrome/browser/process_singleton_linux.cc (right):
> 
> http://codereview.chromium.org/174041/diff/1/5#newcode12
> Line 12: // The destination is a string containing the hostname and process id
> of chrome's
> Exceeds 80 columns
> 
> http://codereview.chromium.org/174041/diff/1/5#newcode42
> Line 42: #include <cstdio>
> We don't use stdio, we use LOG.
> 
> http://codereview.chromium.org/174041/diff/1/5#newcode223
> Line 223: // Unlink a socket path. If the path is a symbol link, then the
symbol
> link
> You should update this comment, since it's not strictly a socket path now. 
> Also, s/symbol/symbolic/ while you're there.
> 
> http://codereview.chromium.org/174041/diff/1/5#newcode235
> Line 235: std::string* hostname,
> indentation is off

[mattm, 2009-08-20 20:54:10]

Turns out resetting the command line was wiping out the extended
--ui-test-timeout that the valgrind tests were setting, causing the tests to
timeout.

This also replaces the sleep calls in the test, though that wasn't actually the
problem.

On 2009/08/19 20:53:27, mattm wrote:
> It seems to fail for me under valgrind even with the trunk version :(
> 
> There appears to be some sort of inter-test interaction, if I run each test
> alone they work.  Gonna have to dig into it some more.
> 
> On 2009/08/19 18:12:24, willchan wrote:
> > LGTM.  You might want to try running in valgrind using chrome_tests.sh or
> > whatever the build bots use, because suzhe was running into valgrind issues
> when
> > he made his last change here.  Thanks for the fix.
> > 
> > http://codereview.chromium.org/174041/diff/1/5
> > File chrome/browser/process_singleton_linux.cc (right):
> > 
> > http://codereview.chromium.org/174041/diff/1/5#newcode12
> > Line 12: // The destination is a string containing the hostname and process
id
> > of chrome's
> > Exceeds 80 columns
> > 
> > http://codereview.chromium.org/174041/diff/1/5#newcode42
> > Line 42: #include <cstdio>
> > We don't use stdio, we use LOG.
> > 
> > http://codereview.chromium.org/174041/diff/1/5#newcode223
> > Line 223: // Unlink a socket path. If the path is a symbol link, then the
> symbol
> > link
> > You should update this comment, since it's not strictly a socket path now. 
> > Also, s/symbol/symbolic/ while you're there.
> > 
> > http://codereview.chromium.org/174041/diff/1/5#newcode235
> > Line 235: std::string* hostname,
> > indentation is off