Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1742333003: Convert the PermissionProvider Mojo interface to plain C++. (Closed)

Created:
4 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@usb_chooser_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert the PermissionProvider Mojo interface to plain C++. This interface allows a separate Mojo service to provide permissions management for a DeviceManager instance. This will be useful if USB device handling is ever moved into a separate process but until then it adds needless complexity to the implementation because access checks are made asynchronous. Make it a normal C++ interface for now. BUG=None Committed: https://crrev.com/d6d8ce13c1ab8141e85717f5832c4ad1af3128bb Cr-Commit-Position: refs/heads/master@{#379393}

Patch Set 1 : #

Patch Set 2 : Pass the permission provider by weak pointer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -425 lines) Patch
M chrome/browser/usb/usb_tab_helper.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/usb/usb_tab_helper.cc View 1 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.h View 1 2 chunks +11 lines, -17 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.cc View 1 4 chunks +28 lines, -44 lines 0 comments Download
M device/usb/mojo/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/usb/mojo/device_impl.h View 1 4 chunks +11 lines, -8 lines 0 comments Download
M device/usb/mojo/device_impl.cc View 1 10 chunks +66 lines, -107 lines 0 comments Download
M device/usb/mojo/device_impl_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M device/usb/mojo/device_manager_impl.h View 1 3 chunks +12 lines, -27 lines 0 comments Download
M device/usb/mojo/device_manager_impl.cc View 1 4 chunks +55 lines, -133 lines 0 comments Download
M device/usb/mojo/device_manager_impl_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M device/usb/mojo/fake_permission_provider.h View 1 2 chunks +10 lines, -18 lines 0 comments Download
M device/usb/mojo/fake_permission_provider.cc View 1 1 chunk +15 lines, -21 lines 0 comments Download
A device/usb/mojo/permission_provider.h View 1 chunk +34 lines, -0 lines 0 comments Download
A device/usb/mojo/permission_provider.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M device/usb/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D device/usb/public/interfaces/permission_provider.mojom View 1 chunk +0 lines, -29 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 9 months ago (2016-03-03 00:09:23 UTC) #3
Reilly Grant (use Gerrit)
I've converted this to use weak pointers.
4 years, 9 months ago (2016-03-04 20:28:32 UTC) #5
Ken Rockot(use gerrit already)
lgtm
4 years, 9 months ago (2016-03-04 23:17:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742333003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742333003/40001
4 years, 9 months ago (2016-03-04 23:23:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-04 23:29:51 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 23:31:06 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6d8ce13c1ab8141e85717f5832c4ad1af3128bb
Cr-Commit-Position: refs/heads/master@{#379393}

Powered by Google App Engine
This is Rietveld 408576698