Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 176823009: Show device information in chrome://gcm-internals page. (Closed)

Created:
6 years, 9 months ago by juyik
Modified:
6 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Show device information in chrome://gcm-internals page. OWNER reviewer: arv BUG=341256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255692

Patch Set 1 #

Total comments: 21

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 12

Patch Set 4 : Resolved merge conflict. #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 2

Patch Set 7 : . #

Total comments: 28

Patch Set 8 : Address code comments. #

Total comments: 14

Patch Set 9 : . #

Patch Set 10 : . #

Total comments: 4

Patch Set 11 : . #

Patch Set 12 : Display android id as well. #

Total comments: 22

Patch Set 13 : . #

Patch Set 14 : make string format portable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -3 lines) Patch
M chrome/browser/resources/gcm_internals.css View 1 2 3 4 5 6 7 8 1 chunk +15 lines, -1 line 0 comments Download
M chrome/browser/resources/gcm_internals.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +65 lines, -0 lines 0 comments Download
M chrome/browser/resources/gcm_internals.js View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +43 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_client_mock.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_client_mock.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +60 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/gcm_internals_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +118 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +16 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +16 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (0 generated)
juyik
6 years, 9 months ago (2014-02-26 22:20:37 UTC) #1
fgorski
Consider surfacing the status of the GCMClient, rather then exposing the client. https://codereview.chromium.org/176823009/diff/1/chrome/browser/resources/gcm_internals.js File chrome/browser/resources/gcm_internals.js ...
6 years, 9 months ago (2014-02-26 23:38:19 UTC) #2
jianli
https://codereview.chromium.org/176823009/diff/1/chrome/browser/resources/gcm_internals.html File chrome/browser/resources/gcm_internals.html (right): https://codereview.chromium.org/176823009/diff/1/chrome/browser/resources/gcm_internals.html#newcode21 chrome/browser/resources/gcm_internals.html:21: GCM Enabled For Current User nit: for https://codereview.chromium.org/176823009/diff/1/chrome/browser/services/gcm/gcm_profile_service.h File ...
6 years, 9 months ago (2014-02-27 00:49:34 UTC) #3
fgorski
https://codereview.chromium.org/176823009/diff/30001/chrome/browser/ui/webui/gcm_internals_ui.cc File chrome/browser/ui/webui/gcm_internals_ui.cc (right): https://codereview.chromium.org/176823009/diff/30001/chrome/browser/ui/webui/gcm_internals_ui.cc#newcode95 chrome/browser/ui/webui/gcm_internals_ui.cc:95: ReturnResults(profile, profile_service, NULL); (profile, NULL, NULL) https://codereview.chromium.org/176823009/diff/30001/chrome/browser/ui/webui/gcm_internals_ui.cc#newcode99 chrome/browser/ui/webui/gcm_internals_ui.cc:99: void ...
6 years, 9 months ago (2014-02-28 19:52:46 UTC) #4
juyik
Addressed all comments. https://codereview.chromium.org/176823009/diff/1/chrome/browser/resources/gcm_internals.html File chrome/browser/resources/gcm_internals.html (right): https://codereview.chromium.org/176823009/diff/1/chrome/browser/resources/gcm_internals.html#newcode21 chrome/browser/resources/gcm_internals.html:21: GCM Enabled For Current User On ...
6 years, 9 months ago (2014-03-01 00:21:56 UTC) #5
fgorski
lgtm with nit https://codereview.chromium.org/176823009/diff/80001/chrome/browser/ui/webui/gcm_internals_ui.cc File chrome/browser/ui/webui/gcm_internals_ui.cc (right): https://codereview.chromium.org/176823009/diff/80001/chrome/browser/ui/webui/gcm_internals_ui.cc#newcode112 chrome/browser/ui/webui/gcm_internals_ui.cc:112: web_ui()->RegisterMessageCallback("getGcmInternalsInfo", nit: move the parameter to ...
6 years, 9 months ago (2014-03-01 22:40:08 UTC) #6
juyik
https://codereview.chromium.org/176823009/diff/80001/chrome/browser/ui/webui/gcm_internals_ui.cc File chrome/browser/ui/webui/gcm_internals_ui.cc (right): https://codereview.chromium.org/176823009/diff/80001/chrome/browser/ui/webui/gcm_internals_ui.cc#newcode112 chrome/browser/ui/webui/gcm_internals_ui.cc:112: web_ui()->RegisterMessageCallback("getGcmInternalsInfo", On 2014/03/01 22:40:09, Filip Gorski wrote: > nit: ...
6 years, 9 months ago (2014-03-04 19:37:24 UTC) #7
jianli
https://codereview.chromium.org/176823009/diff/100001/chrome/browser/services/gcm/gcm_client_mock.cc File chrome/browser/services/gcm/gcm_client_mock.cc (right): https://codereview.chromium.org/176823009/diff/100001/chrome/browser/services/gcm/gcm_client_mock.cc#newcode13 chrome/browser/services/gcm/gcm_client_mock.cc:13: #include "google_apis/gcm/gcm_client.h" nit: not needed since it has already ...
6 years, 9 months ago (2014-03-04 23:47:38 UTC) #8
juyik
https://codereview.chromium.org/176823009/diff/100001/chrome/browser/services/gcm/gcm_client_mock.cc File chrome/browser/services/gcm/gcm_client_mock.cc (right): https://codereview.chromium.org/176823009/diff/100001/chrome/browser/services/gcm/gcm_client_mock.cc#newcode13 chrome/browser/services/gcm/gcm_client_mock.cc:13: #include "google_apis/gcm/gcm_client.h" On 2014/03/04 23:47:39, jianli wrote: > nit: ...
6 years, 9 months ago (2014-03-05 05:08:07 UTC) #9
arv (Not doing code reviews)
https://codereview.chromium.org/176823009/diff/120001/chrome/browser/resources/gcm_internals.css File chrome/browser/resources/gcm_internals.css (right): https://codereview.chromium.org/176823009/diff/120001/chrome/browser/resources/gcm_internals.css#newcode18 chrome/browser/resources/gcm_internals.css:18: text-align: right; or text-align: end; https://codereview.chromium.org/176823009/diff/120001/chrome/browser/resources/gcm_internals.html File chrome/browser/resources/gcm_internals.html (right): ...
6 years, 9 months ago (2014-03-05 14:43:36 UTC) #10
juyik
https://codereview.chromium.org/176823009/diff/120001/chrome/browser/resources/gcm_internals.css File chrome/browser/resources/gcm_internals.css (right): https://codereview.chromium.org/176823009/diff/120001/chrome/browser/resources/gcm_internals.css#newcode18 chrome/browser/resources/gcm_internals.css:18: text-align: right; On 2014/03/05 14:43:36, arv wrote: > or ...
6 years, 9 months ago (2014-03-05 19:05:25 UTC) #11
arv (Not doing code reviews)
https://codereview.chromium.org/176823009/diff/160001/chrome/browser/resources/gcm_internals.js File chrome/browser/resources/gcm_internals.js (right): https://codereview.chromium.org/176823009/diff/160001/chrome/browser/resources/gcm_internals.js#newcode46 chrome/browser/resources/gcm_internals.js:46: if (infos['deviceInfo'] != undefined) { you probably want !== ...
6 years, 9 months ago (2014-03-05 19:44:14 UTC) #12
juyik
https://codereview.chromium.org/176823009/diff/160001/chrome/browser/resources/gcm_internals.js File chrome/browser/resources/gcm_internals.js (right): https://codereview.chromium.org/176823009/diff/160001/chrome/browser/resources/gcm_internals.js#newcode46 chrome/browser/resources/gcm_internals.js:46: if (infos['deviceInfo'] != undefined) { On 2014/03/05 19:44:14, arv ...
6 years, 9 months ago (2014-03-05 19:58:25 UTC) #13
arv (Not doing code reviews)
css/html/js LGTM
6 years, 9 months ago (2014-03-05 20:17:38 UTC) #14
juyik
ping.
6 years, 9 months ago (2014-03-06 01:17:33 UTC) #15
jianli
https://codereview.chromium.org/176823009/diff/200001/chrome/browser/services/gcm/gcm_profile_service.cc File chrome/browser/services/gcm/gcm_profile_service.cc (right): https://codereview.chromium.org/176823009/diff/200001/chrome/browser/services/gcm/gcm_profile_service.cc#newcode276 chrome/browser/services/gcm/gcm_profile_service.cc:276: bool IsGCMClientCreated(); It seems that none is calling it. ...
6 years, 9 months ago (2014-03-06 01:55:20 UTC) #16
juyik
https://codereview.chromium.org/176823009/diff/200001/chrome/browser/services/gcm/gcm_profile_service.cc File chrome/browser/services/gcm/gcm_profile_service.cc (right): https://codereview.chromium.org/176823009/diff/200001/chrome/browser/services/gcm/gcm_profile_service.cc#newcode276 chrome/browser/services/gcm/gcm_profile_service.cc:276: bool IsGCMClientCreated(); On 2014/03/06 01:55:21, jianli wrote: > It ...
6 years, 9 months ago (2014-03-06 02:23:59 UTC) #17
jianli
lgtm
6 years, 9 months ago (2014-03-06 21:54:25 UTC) #18
Dmitry Titov
LGTM
6 years, 9 months ago (2014-03-06 23:28:31 UTC) #19
juyik
The CQ bit was checked by [email protected]
6 years, 9 months ago (2014-03-06 23:43:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/176823009/210001
6 years, 9 months ago (2014-03-06 23:44:34 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
6 years, 9 months ago (2014-03-07 01:43:46 UTC) #22
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=121488
6 years, 9 months ago (2014-03-07 01:43:46 UTC) #23
juyik
The CQ bit was checked by [email protected]
6 years, 9 months ago (2014-03-07 07:07:40 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/176823009/230001
6 years, 9 months ago (2014-03-07 07:08:44 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
6 years, 9 months ago (2014-03-07 07:26:12 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 07:26:13 UTC) #27
juyik
The CQ bit was checked by [email protected]
6 years, 9 months ago (2014-03-07 08:15:32 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/176823009/230001
6 years, 9 months ago (2014-03-07 08:16:46 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
6 years, 9 months ago (2014-03-07 08:24:30 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 08:24:31 UTC) #31
juyik
The CQ bit was checked by [email protected]
6 years, 9 months ago (2014-03-07 17:58:02 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/176823009/230001
6 years, 9 months ago (2014-03-07 18:00:36 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
6 years, 9 months ago (2014-03-07 18:05:05 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 18:05:06 UTC) #35
juyik
The CQ bit was checked by [email protected]
6 years, 9 months ago (2014-03-07 19:26:06 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/176823009/230001
6 years, 9 months ago (2014-03-07 19:26:34 UTC) #37
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 19:52:51 UTC) #38
Message was sent while issue was closed. 
Change committed as 255692

Powered by Google App Engine
This is Rietveld 408576698