Fix two bugs in chrome://extensions/:

Fix two bugs in chrome://extensions/:

* CHECK when reloading installed extension. Caused because we
  were somtimes trying to register for the same notifications
  twice.

* Not able to "Reload" extensions that were loaded with
  "Load Unpacked Extension".

[email protected]

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24882

[Erik does not do reviews, 2009-08-31 16:05:45]

http://codereview.chromium.org/178033/diff/1/3
File chrome/browser/extensions/extensions_ui.cc (right):

http://codereview.chromium.org/178033/diff/1/3#newcode209
Line 209: registrar_.RemoveAll();
Doesn't this mean that you'll only get one load or unload event on the page and
then stop noticing until you reload?

[Aaron Boodman, 2009-08-31 16:59:21]

On Mon, Aug 31, 2009 at 9:05 AM, <[email protected]> wrote:

>
> http://codereview.chromium.org/178033/diff/1/3
> File chrome/browser/extensions/extensions_ui.cc (right):
>
> http://codereview.chromium.org/178033/diff/1/3#newcode209
> Line 209: registrar_.RemoveAll();
> Doesn't this mean that you'll only get one load or unload event on the
> page and then stop noticing until you reload?


Yeah, but all we use the notifications for is to reload, which creates a new
instance of this class and starts it all over again.

- a

[Erik does not do reviews, 2009-08-31 17:00:43]

On Mon, Aug 31, 2009 at 9:58 AM, Aaron Boodman<[email protected]> wrote:
> On Mon, Aug 31, 2009 at 9:05 AM, <[email protected]> wrote:
>>
>> http://codereview.chromium.org/178033/diff/1/3
>> File chrome/browser/extensions/extensions_ui.cc (right):
>>
>> http://codereview.chromium.org/178033/diff/1/3#newcode209
>> Line 209: registrar_.RemoveAll();
>> Doesn't this mean that you'll only get one load or unload event on the
>> page and then stop noticing until you reload?
>
> Yeah, but all we use the notifications for is to reload, which creates a new
> instance of this class and starts it all over again.

ah.  LGTM


> - a
>