Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1806553002: Use WebInspector.UIString (Closed)

Created:
4 years, 9 months ago by sroussey
Modified:
4 years, 9 months ago
Reviewers:
paulirish, dgozman, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use WebInspector.UIString BUG= Committed: https://crrev.com/d1675bc8c91dbce382eca77639858b5475bfb5dd Cr-Commit-Position: refs/heads/master@{#381457}

Patch Set 1 #

Patch Set 2 : Patch with author #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sroussey
Based on feedback before, sounds like this needed to be fixed.
4 years, 9 months ago (2016-03-15 14:56:03 UTC) #2
paulirish
Yup, seems good here. dgozman can you verify?
4 years, 9 months ago (2016-03-15 17:37:20 UTC) #4
paulirish
sroussey, since this'll land before the other CL, you should add yourself to AUTHORS over ...
4 years, 9 months ago (2016-03-15 17:38:03 UTC) #5
pfeldman
lgtm
4 years, 9 months ago (2016-03-15 18:05:23 UTC) #8
paulirish
steve, after you add the AUTHORS file here and upload that patch.. you can then ...
4 years, 9 months ago (2016-03-16 02:11:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806553002/20001
4 years, 9 months ago (2016-03-16 14:10:57 UTC) #12
sroussey
On 2016/03/16 at 02:11:33, paulirish wrote: > steve, after you add the AUTHORS file here ...
4 years, 9 months ago (2016-03-16 14:11:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 15:50:14 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 15:51:29 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1675bc8c91dbce382eca77639858b5475bfb5dd
Cr-Commit-Position: refs/heads/master@{#381457}

Powered by Google App Engine
This is Rietveld 408576698