Don't rename references to functions that originate from template args.

Don't rename references to functions that originate from template args.

BUG=595577
Committed: https://crrev.com/c13719228662d502c7b1b5973edbcb69236b8203
Cr-Commit-Position: refs/heads/master@{#382160}

[dcheng, 2016-03-17 03:50:32]

Description was changed from

==========
Gah

BUG=
==========

to

==========
Don't rename references to functions that originate from template args.

BUG=595577
==========

[dcheng, 2016-03-17 03:50:32]

[email protected] changed reviewers:
+ [email protected]

[dcheng, 2016-03-17 04:03:39]

https://codereview.chromium.org/1806903003/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (left):

https://codereview.chromium.org/1806903003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:57:
AST_MATCHER(clang::FunctionDecl, isDefaulted) {
No longer needed, yay!

https://codereview.chromium.org/1806903003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:206: bool
was_number = false;
These were giving me warnings.

https://codereview.chromium.org/1806903003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:406:
assert(decl.shadow_size() > 0);
I did some refactoring in this area when trying to fix another bug and gave up.
I figured that the reorganization of code doesn't really hurt and might be
useful later, so I just left it.

https://codereview.chromium.org/1806903003/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:443: const char
TargetNodeTraits<clang::NamedDecl>::kName[] = "decl";
Ditto: these were incidental cleanups when I was trying to fix
https://crbug.com/584408

[danakj, 2016-03-18 23:42:05]

LGTM

https://codereview.chromium.org/1806903003/diff/60001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (left):

https://codereview.chromium.org/1806903003/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:206: bool
was_number = false;
Oh thanks, I tried to look for unused stuff when I deleted the enums, woops.

https://codereview.chromium.org/1806903003/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:441: static const
char* GetType() { return "NamedDecl"; }
rip debugging string

can we keep the (unused) GetType()s?

https://codereview.chromium.org/1806903003/diff/60001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1806903003/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:647: // Ignore
template substitutions
.

[dcheng, 2016-03-19 00:10:33]

The CQ bit was checked by [email protected]

[dcheng, 2016-03-19 00:10:34]

https://codereview.chromium.org/1806903003/diff/60001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (left):

https://codereview.chromium.org/1806903003/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:441: static const
char* GetType() { return "NamedDecl"; }
On 2016/03/18 at 23:42:05, danakj wrote:
> rip debugging string
> 
> can we keep the (unused) GetType()s?

Done.

[dcheng, 2016-03-19 00:10:34]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/1806903003/#ps100001
(title: "Add a period and GetType")

[commit-bot: I haz the power, 2016-03-19 00:10:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806903003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806903003/100001

[commit-bot: I haz the power, 2016-03-19 01:02:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-19 01:04:46]

Description was changed from

==========
Don't rename references to functions that originate from template args.

BUG=595577
==========

to

==========
Don't rename references to functions that originate from template args.

BUG=595577

Committed: https://crrev.com/c13719228662d502c7b1b5973edbcb69236b8203
Cr-Commit-Position: refs/heads/master@{#382160}
==========

[commit-bot: I haz the power, 2016-03-19 01:04:47]

Patchset 6 (id:??) landed as
https://crrev.com/c13719228662d502c7b1b5973edbcb69236b8203
Cr-Commit-Position: refs/heads/master@{#382160}