Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1885093004: [libfuzzer] fetch libfuzzer on mac and register it in build root. (Closed)

Created:
4 years, 8 months ago by aizatsky
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] fetch libfuzzer on mac and register it in build root. Partial resubmit of https://crrev.com/e9aba58f6cbfee6fec2af0ec4832a3c23ec66b9f BUG=597066 Committed: https://crrev.com/af4961161ff330e5ae98fe14a67809ecf387c0e8 Cr-Commit-Position: refs/heads/master@{#387670}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M BUILD.gn View 3 chunks +8 lines, -10 lines 0 comments Download
M DEPS View 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 14 (5 generated)
aizatsky
4 years, 8 months ago (2016-04-14 22:47:17 UTC) #3
Dirk Pranke
lgtm if I understood correctly and the comment should be updated (and is). https://codereview.chromium.org/1885093004/diff/1/DEPS File ...
4 years, 8 months ago (2016-04-14 23:20:39 UTC) #4
aizatsky
On 2016/04/14 23:20:39, Dirk Pranke wrote: > lgtm if I understood correctly and the comment ...
4 years, 8 months ago (2016-04-14 23:24:38 UTC) #5
Dirk Pranke
On 2016/04/14 23:24:38, aizatsky wrote: > On 2016/04/14 23:20:39, Dirk Pranke wrote: > > lgtm ...
4 years, 8 months ago (2016-04-14 23:29:31 UTC) #6
Oliver Chang
lgtm https://codereview.chromium.org/1885093004/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1885093004/diff/1/DEPS#newcode286 DEPS:286: # Used for building libFuzzers (only supports Linux). ...
4 years, 8 months ago (2016-04-14 23:30:22 UTC) #7
Oliver Chang
On 2016/04/14 23:30:22, Oliver Chang wrote: > lgtm > > https://codereview.chromium.org/1885093004/diff/1/DEPS > File DEPS (right): ...
4 years, 8 months ago (2016-04-14 23:30:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885093004/1
4 years, 8 months ago (2016-04-15 18:25:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 19:26:45 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:28:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af4961161ff330e5ae98fe14a67809ecf387c0e8
Cr-Commit-Position: refs/heads/master@{#387670}

Powered by Google App Engine
This is Rietveld 408576698