Gerrit git cl upload: implement setting cc and reviewers.

Gerrit git cl upload: implement setting cc and reviewers.

[email protected],[email protected]
BUG=323819
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299887

[tandrii(chromium), 2016-04-13 12:39:46]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 12:39:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885883002/1

[Michael Achenbach, 2016-04-13 12:43:04]

lgtm

https://codereview.chromium.org/1885883002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1885883002/diff/1/git_cl.py#newcode2394
git_cl.py:2394: cc = self.GetCCList().split(',')
Can there be spaces after the comma by any chance?

[Bons, 2016-04-13 12:44:03]

lgtm

https://codereview.chromium.org/1885883002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/1885883002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:810: ref_suffix += ',' + ','.join('r=%s' % email for email
in sorted(reviewers))
>80chars

[commit-bot: I haz the power, 2016-04-13 12:45:01]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-04-13 12:45:03]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[tandrii(chromium), 2016-04-13 12:53:02]

The CQ bit was checked by [email protected]

[tandrii(chromium), 2016-04-13 12:53:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/1885883002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-04-13 12:53:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885883002/20001

[tandrii(chromium), 2016-04-13 12:53:14]

https://codereview.chromium.org/1885883002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1885883002/diff/1/git_cl.py#newcode2394
git_cl.py:2394: cc = self.GetCCList().split(',')
On 2016/04/13 12:43:04, Michael Achenbach wrote:
> Can there be spaces after the comma by any chance?

good point, stripped.

[commit-bot: I haz the power, 2016-04-13 12:56:03]

Description was changed from

==========
Gerrit git cl upload: implement setting cc and reviewers.

[email protected],[email protected]
BUG=323819
==========

to

==========
Gerrit git cl upload: implement setting cc and reviewers.

[email protected],[email protected]
BUG=323819

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299887
==========

[commit-bot: I haz the power, 2016-04-13 12:56:04]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299887