Pass FileHandlersInfo to [Create|Update]PlatformShortcuts.

Pass FileHandlersInfo to [Create|Update]PlatformShortcuts.

This pulls FileHandlerInfo out of file_handlers_parse.

This allows [Create|Update]PlatformShortcuts to register the shortcut as a file
handler in the OS.

BUG=261427
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263217

[benwells, 2014-03-11 03:13:06]

https://codereview.chromium.org/189753003/diff/1/chrome/browser/shell_integra...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/189753003/diff/1/chrome/browser/shell_integra...
chrome/browser/shell_integration.h:14: #include
"chrome/common/extensions/api/file_handlers/file_handlers_parser.h"
This dependency doesn't look like a great thing to bring into such a core class.
From this change it is hard to tell how it is needed. Is there some other way to
do what you need?

[jackhou1, 2014-04-08 07:18:03]

PTAL

[benwells, 2014-04-08 22:15:40]

Just had a quick look.

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
chrome/browser/shell_integration.h:14: #include
"chrome/common/extensions/file_handler_info.h"
This is another bad dependency to have here. Is there some reason this can't be
in web_app.h? Alternatively, maybe FileHandlersInfo can just go into
file_handler_info.h.

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
chrome/browser/shell_integration.h:119: const
std::vector<extensions::FileHandlerInfo>* handlers;
Why is a struct needed, it seems to be just a pointer to a vector.

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app.h (right):

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/web_appli...
chrome/browser/web_applications/web_app.h:44: typedef base::Callback<void(const
ShellIntegration::ShortcutInfo&,
Does this need to be in the header file?

[jackhou1, 2014-04-08 23:29:02]

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
chrome/browser/shell_integration.h:14: #include
"chrome/common/extensions/file_handler_info.h"
On 2014/04/08 22:15:40, benwells wrote:
> This is another bad dependency to have here. Is there some reason this can't
be
> in web_app.h? Alternatively, maybe FileHandlersInfo can just go into
> file_handler_info.h.

Do you mean FileHandlersInfo should go in web_app.h? I agree. It's only here
because ShortcutInfo is. Should I move them both to web_app.h?

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
chrome/browser/shell_integration.h:119: const
std::vector<extensions::FileHandlerInfo>* handlers;
On 2014/04/08 22:15:40, benwells wrote:
> Why is a struct needed, it seems to be just a pointer to a vector.

It'll later need to hold a gfx::ImageFamily for each file handler.

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app.h (right):

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/web_appli...
chrome/browser/web_applications/web_app.h:44: typedef base::Callback<void(const
ShellIntegration::ShortcutInfo&,
On 2014/04/08 22:15:40, benwells wrote:
> Does this need to be in the header file?

Done.

[benwells, 2014-04-09 03:46:39]

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
chrome/browser/shell_integration.h:14: #include
"chrome/common/extensions/file_handler_info.h"
On 2014/04/08 23:29:03, jackhou1 wrote:
> On 2014/04/08 22:15:40, benwells wrote:
> > This is another bad dependency to have here. Is there some reason this can't
> be
> > in web_app.h? Alternatively, maybe FileHandlersInfo can just go into
> > file_handler_info.h.
> 
> Do you mean FileHandlersInfo should go in web_app.h? I agree. It's only here
> because ShortcutInfo is. Should I move them both to web_app.h?

Yes that was what I meant, or just put it directly in file_handler_info.h (that
feels even better). Is ShortcutInfo used by anything else?

[jackhou1, 2014-04-10 02:38:23]

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/189753003/diff/20001/chrome/browser/shell_int...
chrome/browser/shell_integration.h:14: #include
"chrome/common/extensions/file_handler_info.h"
On 2014/04/09 03:46:40, benwells wrote:
> On 2014/04/08 23:29:03, jackhou1 wrote:
> > On 2014/04/08 22:15:40, benwells wrote:
> > > This is another bad dependency to have here. Is there some reason this
can't
> > be
> > > in web_app.h? Alternatively, maybe FileHandlersInfo can just go into
> > > file_handler_info.h.
> > 
> > Do you mean FileHandlersInfo should go in web_app.h? I agree. It's only here
> > because ShortcutInfo is. Should I move them both to web_app.h?
> 
> Yes that was what I meant, or just put it directly in file_handler_info.h
(that
> feels even better). Is ShortcutInfo used by anything else?

Done.

ShortcutInfo is used in a whole bunch of places, but I think only in the context
of apps (not shell integration of Chrome). I'll put together another CL for it.

[benwells, 2014-04-11 00:53:34]

lgtm with a nit.

https://codereview.chromium.org/189753003/diff/60001/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app.cc (right):

https://codereview.chromium.org/189753003/diff/60001/chrome/browser/web_appli...
chrome/browser/web_applications/web_app.cc:248:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
Nit: This should just call CreateShortcutsWithInfoOnFileThread with null file
handlers info instead of dupplicating the whole thing.

[jackhou1, 2014-04-11 03:04:40]

https://codereview.chromium.org/189753003/diff/60001/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app.cc (right):

https://codereview.chromium.org/189753003/diff/60001/chrome/browser/web_appli...
chrome/browser/web_applications/web_app.cc:248:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
On 2014/04/11 00:53:34, benwells wrote:
> Nit: This should just call CreateShortcutsWithInfoOnFileThread with null file
> handlers info instead of dupplicating the whole thing.

Done.

[Matt Giuca, 2014-04-11 03:19:50]

Looks good lgtm.

This will help me a lot, thank you. I don't think it will conflict with my stuff
since I hadn't actually gotten around to using the real file handler info from
the manifest.

[jackhou1, 2014-04-11 04:24:37]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-04-11 04:25:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/189753003/100001

[commit-bot: I haz the power, 2014-04-11 06:12:04]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2014-04-11 06:12:05]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[jackhou1, 2014-04-11 08:10:13]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-04-11 08:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/189753003/120001

[commit-bot: I haz the power, 2014-04-11 13:18:04]

Change committed as 263217