Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1962273002: Fix worker-js-frames.html expectation (Closed)

Created:
4 years, 7 months ago by keishi
Modified:
4 years, 7 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix worker-js-frames.html expectation Looks like r381103 reduced the trace events from the debugger causing the test results to change. The oilpan specific results seems to have resolved sometime before r381247. BUG=585328 Committed: https://crrev.com/7a7fdbdbcff3327ff7f4d624deeef0faea2d8162 Cr-Commit-Position: refs/heads/master@{#392840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/worker-js-frames.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
keishi
4 years, 7 months ago (2016-05-10 12:29:08 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-10 13:08:08 UTC) #5
dgozman
lgtm
4 years, 7 months ago (2016-05-10 16:17:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962273002/1
4 years, 7 months ago (2016-05-11 02:26:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 03:24:06 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a7fdbdbcff3327ff7f4d624deeef0faea2d8162 Cr-Commit-Position: refs/heads/master@{#392840}
4 years, 7 months ago (2016-05-11 03:25:20 UTC) #12
ananta
4 years, 7 months ago (2016-05-11 23:32:38 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1970983002/ by [email protected].

The reason for reverting is: Looks like this causes webkit windows redness.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/42208

Please verify and reland.

Powered by Google App Engine
This is Rietveld 408576698