Mojo C++ bindings: add StringTraits and ArrayTraits for STL types.

Mojo C++ bindings: add StringTraits and ArrayTraits for STL types.

It means mojom string and array can be automatically convert to/from std::string and std::vector, respectively.

This CL also allows array of custom-mapped objects.

BUG=577686
Committed: https://crrev.com/dec89e06f5f7d1c747df774086480b739fb0accc
Cr-Commit-Position: refs/heads/master@{#393567}

[yzshen1, 2016-05-11 17:14:13]

[email protected] changed reviewers:
+ [email protected]

[yzshen1, 2016-05-11 17:14:13]

Hi, Ken.

Please take a look. Thanks!

[Ken Rockot(use gerrit already), 2016-05-13 14:35:52]

lgtm

https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right):

https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:17: array<string>
f_array_string;
nit: I think it would be clearer for readers if these fields were
f_array_of_strings and f_array_of_elements.

extra nit: I think the term "element" could also be slightly confusing as it's
commonly used to refer to generic array contents. What do you think about making
the struct a NestedStructWithTraits and the field below f_array_of_structs?

[yzshen1, 2016-05-13 16:01:18]

Thanks!

https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right):

https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:17: array<string>
f_array_string;
On 2016/05/13 14:35:51, Ken Rockot wrote:
> nit: I think it would be clearer for readers if these fields were
> f_array_of_strings and f_array_of_elements.
> 
> extra nit: I think the term "element" could also be slightly confusing as it's
> commonly used to refer to generic array contents. What do you think about
making
> the struct a NestedStructWithTraits and the field below f_array_of_structs?

Thanks!

I changed to use NestedStructWithTraits, f_string_array and f_struct_array. Does
that sound okay?

[Ken Rockot(use gerrit already), 2016-05-13 16:01:58]

On 2016/05/13 at 16:01:18, yzshen wrote:
> Thanks!
> 
>
https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
> File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right):
> 
>
https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
> mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:17:
array<string> f_array_string;
> On 2016/05/13 14:35:51, Ken Rockot wrote:
> > nit: I think it would be clearer for readers if these fields were
> > f_array_of_strings and f_array_of_elements.
> > 
> > extra nit: I think the term "element" could also be slightly confusing as
it's
> > commonly used to refer to generic array contents. What do you think about
making
> > the struct a NestedStructWithTraits and the field below f_array_of_structs?
> 
> Thanks!
> 
> I changed to use NestedStructWithTraits, f_string_array and f_struct_array.
Does that sound okay?

Perfect, thanks

[Ken Rockot(use gerrit already), 2016-05-13 16:02:10]

On 2016/05/13 at 16:01:58, Ken Rockot wrote:
> On 2016/05/13 at 16:01:18, yzshen wrote:
> > Thanks!
> > 
> >
https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
> > File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right):
> > 
> >
https://codereview.chromium.org/1967703004/diff/20001/mojo/public/interfaces/...
> > mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:17:
array<string> f_array_string;
> > On 2016/05/13 14:35:51, Ken Rockot wrote:
> > > nit: I think it would be clearer for readers if these fields were
> > > f_array_of_strings and f_array_of_elements.
> > > 
> > > extra nit: I think the term "element" could also be slightly confusing as
it's
> > > commonly used to refer to generic array contents. What do you think about
making
> > > the struct a NestedStructWithTraits and the field below
f_array_of_structs?
> > 
> > Thanks!
> > 
> > I changed to use NestedStructWithTraits, f_string_array and f_struct_array.
Does that sound okay?
> 
> Perfect, thanks

(still lgtm)

[yzshen1, 2016-05-13 16:03:45]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-05-13 16:04:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967703004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967703004/40001

[commit-bot: I haz the power, 2016-05-13 17:29:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 17:30:50]

Description was changed from

==========
Mojo C++ bindings: add StringTraits and ArrayTraits for STL types.

It means mojom string and array can be automatically convert to/from std::string
and std::vector, respectively.

This CL also allows array of custom-mapped objects.

BUG=577686
==========

to

==========
Mojo C++ bindings: add StringTraits and ArrayTraits for STL types.

It means mojom string and array can be automatically convert to/from std::string
and std::vector, respectively.

This CL also allows array of custom-mapped objects.

BUG=577686

Committed: https://crrev.com/dec89e06f5f7d1c747df774086480b739fb0accc
Cr-Commit-Position: refs/heads/master@{#393567}
==========

[commit-bot: I haz the power, 2016-05-13 17:30:51]

Patchset 3 (id:??) landed as
https://crrev.com/dec89e06f5f7d1c747df774086480b739fb0accc
Cr-Commit-Position: refs/heads/master@{#393567}