cc: Use ScreenSpaceTransform to determine content scale

cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

Because of the way sublayer scale works, the scale component of
TargetSpaceTransform is the same as the scale component of
ScreenSpaceTransform.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c5d4fb49b677d6c68687dd3dcca8c0000d786169
Cr-Commit-Position: refs/heads/master@{#396389}

[sunxd, 2016-05-26 18:02:37]

Description was changed from

==========
cc: Use ScreenSpaceTransform to determine content scale (FOR TESTING)

This is a temp change for testing.

BUG=597721
==========

to

==========
cc: Use ScreenSpaceTransform to determine content scale (FOR TESTING)

This is a temp change for testing.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-05-26 21:28:09]

Description was changed from

==========
cc: Use ScreenSpaceTransform to determine content scale (FOR TESTING)

This is a temp change for testing.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-05-26 21:28:09]

[email protected] changed reviewers:
+ [email protected], [email protected], [email protected]

[jaydasika, 2016-05-26 21:42:40]

lgtm % (ajuma or vollick)

[ajuma, 2016-05-26 21:45:10]

lgtm. Might be worth mentioning in the description that because of the way
sublayer scale works, the scale component of TargetSpaceTransform is the same as
the scale component of ScreenSpaceTransform.

https://codereview.chromium.org/2011063002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2011063002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:535: crbug.com/597721
compositing/overflow/nested-render-surfaces-with-rotation.html [
NeedsManualRebaseline ]
This should be NeedsRebaseline (so the auto-rebaseline bot rebaselines it for
you)

[sunxd, 2016-05-27 01:21:10]

Description was changed from

==========
cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

Because of the way sublayer scale works, the scale component of
TargetSpaceTransform is the same as the scale component of
ScreenSpaceTransform.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-05-27 01:23:56]

https://codereview.chromium.org/2011063002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2011063002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:535: crbug.com/597721
compositing/overflow/nested-render-surfaces-with-rotation.html [
NeedsManualRebaseline ]
On 2016/05/26 21:45:10, ajuma wrote:
> This should be NeedsRebaseline (so the auto-rebaseline bot rebaselines it for
> you)

Done.

[sunxd, 2016-05-27 01:24:00]

The CQ bit was checked by [email protected]

[sunxd, 2016-05-27 01:24:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/2011063002/#ps60001
(title: "Make layout test need-auto-rebaseline")

[commit-bot: I haz the power, 2016-05-27 01:24:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011063002/60001

[commit-bot: I haz the power, 2016-05-27 04:40:19]

Description was changed from

==========
cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

Because of the way sublayer scale works, the scale component of
TargetSpaceTransform is the same as the scale component of
ScreenSpaceTransform.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

Because of the way sublayer scale works, the scale component of
TargetSpaceTransform is the same as the scale component of
ScreenSpaceTransform.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-27 04:40:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-27 04:41:59]

Description was changed from

==========
cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

Because of the way sublayer scale works, the scale component of
TargetSpaceTransform is the same as the scale component of
ScreenSpaceTransform.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use ScreenSpaceTransform to determine content scale

ScreenSpaceTransform should be used to determine the ideal content
scale as TargetSpaceTransform will no longer be cached in transform
tree.

Because of the way sublayer scale works, the scale component of
TargetSpaceTransform is the same as the scale component of
ScreenSpaceTransform.

The switching results in a different behavior because of snapping
float transforms, thus a manual rebaseline is needed for layout test.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c5d4fb49b677d6c68687dd3dcca8c0000d786169
Cr-Commit-Position: refs/heads/master@{#396389}
==========

[commit-bot: I haz the power, 2016-05-27 04:42:00]

Patchset 4 (id:??) landed as
https://crrev.com/c5d4fb49b677d6c68687dd3dcca8c0000d786169
Cr-Commit-Position: refs/heads/master@{#396389}