Do not suppress referrers for '<a ... rel="noopener">'.

Do not suppress referrers for '<a ... rel="noopener">'.

The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.

BUG=618532
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4c82bb5386376f64c2a8eb9258ea397cba04b7d1
Cr-Commit-Position: refs/heads/master@{#399391}

[Mike West, 2016-06-10 08:20:55]

Description was changed from

==========
Do not suppress referrers for '<a ... rel="noopener">'.

The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.

BUG=618532
==========

to

==========
Do not suppress referrers for '<a ... rel="noopener">'.

The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.

BUG=618532
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mike West, 2016-06-10 08:26:05]

[email protected] changed reviewers:
+ [email protected]

[Mike West, 2016-06-10 08:26:06]

Jochen, do you have a few minutes to take a look at this patch?

https://codereview.chromium.org/2058693002/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/2058693002/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_impl.cc:2073: OpenURLParams
open_params(params.target_url, params.referrer, CURRENT_TAB,
This is the only behavioral change in this patch; the WebKit bits are just inert
refactoring so that we're not passing the data around as part of
'FrameLoadRequest' and as distinct booleans.

Since we're already checking the referrer state in
'FrameLoader::setReferrerForFrameRequest', we can simply rely on Blink to send
the right information for 'noreferrer', rather than conflating the opener
behavior and the referrer behavior here.

[jochen (gone - plz use gerrit), 2016-06-10 08:39:04]

lgtm

[Mike West, 2016-06-10 09:32:37]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-06-10 09:32:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058693002/1

[commit-bot: I haz the power, 2016-06-10 12:50:21]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-06-10 12:50:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike West, 2016-06-10 17:20:08]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-06-10 17:20:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058693002/1

[commit-bot: I haz the power, 2016-06-10 21:03:09]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-06-10 21:03:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike West, 2016-06-11 05:31:25]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-06-11 05:31:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058693002/1

[commit-bot: I haz the power, 2016-06-11 09:32:09]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-06-11 09:32:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike West, 2016-06-12 15:00:24]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-06-12 15:00:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058693002/1

[commit-bot: I haz the power, 2016-06-12 16:46:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-12 16:48:03]

Description was changed from

==========
Do not suppress referrers for '<a ... rel="noopener">'.

The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.

BUG=618532
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Do not suppress referrers for '<a ... rel="noopener">'.

The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.

BUG=618532
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4c82bb5386376f64c2a8eb9258ea397cba04b7d1
Cr-Commit-Position: refs/heads/master@{#399391}
==========

[commit-bot: I haz the power, 2016-06-12 16:48:04]

Patchset 1 (id:??) landed as
https://crrev.com/4c82bb5386376f64c2a8eb9258ea397cba04b7d1
Cr-Commit-Position: refs/heads/master@{#399391}

[hcarmona, 2016-06-14 19:38:17]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2067993002/ by [email protected].

The reason for reverting is: Reverting for http://crbug.com/619856.