Refactor MessageCenterSettingsController.

Refactor MessageCenterSettingsController.

The CL does refactoring for MessageCenterSettingsController to get rid
of #ifdef macros for CHROME_OS.

1. Define NotifierSource abstract class that provides a list of specific
   type of notifiers.
2. Define subclass for each notifier type (APPLICATION, WEB_PAGE,
   SYSTEM_COMPONENT, ARC_APPLICATION).
3. Let MessageCenterSettingsController delegate to each source.

BUG=620184
TEST=None

Committed: https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa
Cr-Commit-Position: refs/heads/master@{#400867}

[hirono, 2016-06-15 07:03:24]

[email protected] changed reviewers:
+ [email protected]

[hirono, 2016-06-15 07:03:25]

PTAL.
This is TODO refactoring from crrev.com/2054043002.
The base patch crrev.com/2065493005 is under review.

Thank you!

[dewittj, 2016-06-15 20:46:03]

fyi if you set your git branch upstream to the branch with the parent issue, it
will automatically link new patchsets such that you can run the trybots

[hirono, 2016-06-16 03:21:08]

Thant's useful! Thank you

[dewittj, 2016-06-16 19:45:36]

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/message_center_settings_controller.cc:121: class
ApplicationNotifiereSource : public NotifierSource,
I think this deserves its own h/cc files.  Probably better named
ExtensionNotifierSource?

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/message_center_settings_controller.cc:124: explicit
ApplicationNotifiereSource(
This should be spelled ApplicationNotifierSource, right?

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notifier_source.cc (right):

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notifier_source.cc:7:
NotifierSource::NotifierSource(message_center::NotifierSettingsObserver* parent)
Not sure this is totally necessary in the interface file.. I'd put it on any
subclass that requires it.

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notifier_source.cc:14: void
NotifierSource::OnNotifierSettingsClosing() {}
this could be inlined in the .h file

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notifier_source.h (right):

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notifier_source.h:24: virtual ~NotifierSource();
This could be more concisely spelled

virtual ~NotifierSource() = default;

https://codereview.chromium.org/2064363002/diff/40001/chrome/browser/notifica...
File chrome/browser/notifications/message_center_settings_controller.h (right):

https://codereview.chromium.org/2064363002/diff/40001/chrome/browser/notifica...
chrome/browser/notifications/message_center_settings_controller.h:102: //
Overridden from message_center::NotifierSettingsObserver.
While I agree that pulling these out is a nice thing to do,  I'm not sure that
this should implement NotifierSettingsObserver; it's confusing that this is a
NSObserver as well as an NSProvider.

So I'd rename these to:

DispatchUpdateIconImage
DispatchNotifierGroupChanged
DispatchNotifierEnabledChanged

or some similar prefix to make it clear that they are for the purpose of telling
all the observers that something happened.

Then I'd remove the inheritance from NotifierSettingsObserver.

You can maybe add an OnIconImageUpdated to NotifierSettingsProvider so that your
ApplicationNotifiereSource can take a NotifierSettingsProvider*.

[hirono, 2016-06-17 04:56:47]

Thank you!

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/message_center_settings_controller.cc:121: class
ApplicationNotifiereSource : public NotifierSource,
On 2016/06/16 19:45:36, dewittj wrote:
> I think this deserves its own h/cc files.  Probably better named
> ExtensionNotifierSource?

Separating files is done. The names of source classes are corresponding to
NotifierType enum.
https://cs.chromium.org/chromium/src/ui/message_center/notifier_settings.h?rc...

APPLICATION -> ApplicationNotifierSource
ARC_APPLICATION -> ArcApplicationNotifierSourceChromeOS
WEB_PAGE -> WebPageNotifierSource
SYSMTE_COMPONENT -> SystemComponentNotifierSourceChromeOS

WDYT?

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/message_center_settings_controller.cc:124: explicit
ApplicationNotifiereSource(
On 2016/06/16 19:45:36, dewittj wrote:
> This should be spelled ApplicationNotifierSource, right?

Oops, yes!

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notifier_source.cc (right):

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notifier_source.cc:7:
NotifierSource::NotifierSource(message_center::NotifierSettingsObserver* parent)
On 2016/06/16 19:45:36, dewittj wrote:
> Not sure this is totally necessary in the interface file.. I'd put it on any
> subclass that requires it.

Done.

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notifier_source.cc:14: void
NotifierSource::OnNotifierSettingsClosing() {}
On 2016/06/16 19:45:36, dewittj wrote:
> this could be inlined in the .h file

Done.

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notifier_source.h (right):

https://codereview.chromium.org/2064363002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notifier_source.h:24: virtual ~NotifierSource();
On 2016/06/16 19:45:36, dewittj wrote:
> This could be more concisely spelled
> 
> virtual ~NotifierSource() = default;

Done.

[hirono, 2016-06-20 01:51:51]

friendly ping

[dewittj, 2016-06-20 17:14:22]

thank  you for doing this!

lgtm

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
chrome/browser/notifications/message_center_settings_controller.cc:134: // FOr
system components.
nit: FOr -> For
or remove the comment, it's fairly obvious at this point.

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
File chrome/browser/notifications/notifier_source.h (right):

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
chrome/browser/notifications/notifier_source.h:31: NotifierSource() = default;
Do you need this?

[hirono, 2016-06-21 00:45:53]

The CQ bit was checked by [email protected]

[hirono, 2016-06-21 00:45:53]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/2064363002/#ps200001
(title: "Fix misspell.")

[hirono, 2016-06-21 00:46:02]

Thank you!

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
chrome/browser/notifications/message_center_settings_controller.cc:134: // FOr
system components.
On 2016/06/20 17:14:22, dewittj wrote:
> nit: FOr -> For
> or remove the comment, it's fairly obvious at this point.

Done.

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
File chrome/browser/notifications/notifier_source.h (right):

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
chrome/browser/notifications/notifier_source.h:31: NotifierSource() = default;
On 2016/06/20 17:14:22, dewittj wrote:
> Do you need this?

Yes, because DISALLOW_COPY_AND_ASSIGN adds private constructor, we need to add
default constructor here explicitly.

[hirono, 2016-06-21 00:46:03]

Thank you!

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
chrome/browser/notifications/message_center_settings_controller.cc:134: // FOr
system components.
On 2016/06/20 17:14:22, dewittj wrote:
> nit: FOr -> For
> or remove the comment, it's fairly obvious at this point.

Done.

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
File chrome/browser/notifications/notifier_source.h (right):

https://codereview.chromium.org/2064363002/diff/160001/chrome/browser/notific...
chrome/browser/notifications/notifier_source.h:31: NotifierSource() = default;
On 2016/06/20 17:14:22, dewittj wrote:
> Do you need this?

Yes, because DISALLOW_COPY_AND_ASSIGN adds private constructor, we need to add
default constructor here explicitly.

[commit-bot: I haz the power, 2016-06-21 00:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2064363002/200001

[commit-bot: I haz the power, 2016-06-21 01:28:57]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-06-21 01:31:34]

Description was changed from

==========
Refactor MessageCenterSettingsController.

The CL does refactoring for MessageCenterSettingsController to get rid
of #ifdef macros for CHROME_OS.

1. Define NotifierSource abstract class that provides a list of specific
   type of notifiers.
2. Define subclass for each notifier type (APPLICATION, WEB_PAGE,
   SYSTEM_COMPONENT, ARC_APPLICATION).
3. Let MessageCenterSettingsController delegate to each source.

BUG=620184
TEST=None
==========

to

==========
Refactor MessageCenterSettingsController.

The CL does refactoring for MessageCenterSettingsController to get rid
of #ifdef macros for CHROME_OS.

1. Define NotifierSource abstract class that provides a list of specific
   type of notifiers.
2. Define subclass for each notifier type (APPLICATION, WEB_PAGE,
   SYSTEM_COMPONENT, ARC_APPLICATION).
3. Let MessageCenterSettingsController delegate to each source.

BUG=620184
TEST=None

Committed: https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa
Cr-Commit-Position: refs/heads/master@{#400867}
==========

[commit-bot: I haz the power, 2016-06-21 01:31:35]

Patchset 11 (id:??) landed as
https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa
Cr-Commit-Position: refs/heads/master@{#400867}