Issue 2064543002: Add a new rate based sending connection option which uses the pacing rate to keep the bytes_in_flig…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2064543002: Add a new rate based sending connection option which uses the pacing rate to keep the bytes_in_flig… (Closed)

Created:
4 years, 6 months ago by jokulik

Modified:
4 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett

Base URL:
https://chromium.googlesource.com/chromium/src.git@124273380

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a new rate based sending connection option which uses the pacing rate to keep the bytes_in_flight close to the CWND. Protected by flag quic_rate_based_sending. Merge internal change: 124302573 [email protected] BUG=

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -25 lines)			Patch
M	net/quic/congestion_control/pacing_sender.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/congestion_control/pacing_sender.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	net/quic/congestion_control/pacing_sender_test.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/congestion_control/send_algorithm_interface.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender_base.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender_base.cc	View		5 chunks	+19 lines, -1 line	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender_bytes_test.cc	View		1 chunk	+36 lines, -2 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender_packets_test.cc	View		1 chunk	+36 lines, -2 lines	0 comments	Download
M	net/quic/crypto/crypto_protocol.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_flags.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_http_stream_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2065463002 Patch 40001

Dependent Patchsets:

Issue 2060723002 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages