Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 207003: GTK: Don't put a blank line in the tooltip for nameless bookmark bar bookmark... (Closed)

Created:
11 years, 3 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

GTK: Don't put a blank line in the tooltip for nameless bookmark bar bookmarks. Man, why is it so hard to get this right?? BUG=none TEST=look at tooltips for a bookmark that has a) no title b) no url (folder) c) both title and url Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26418

Patch Set 1 #

Patch Set 2 : easier way #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/gtk/bookmark_utils_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
11 years, 3 months ago (2009-09-16 22:23:15 UTC) #1
Elliot Glaysher
11 years, 3 months ago (2009-09-16 22:37:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698