Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2073193003: Expand memoized_unittest and clarify error message. (Closed)

Created:
4 years, 6 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand memoized_unittest and clarify error message. Specifically: - Improve style in memoized_unittest - Make test methods clearer - Make error message clearer if a non-hashable type is passed to a memoized function - Add unit test for this The purpose of this change is just to clarify the code. Committed: https://crrev.com/550547d0385f1cb8a905d4322a7ae7452a0d3e7b Cr-Commit-Position: refs/heads/master@{#401337}

Patch Set 1 #

Patch Set 2 : Changed the way TypeError is raised #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/memoized_unittest.py View 1 chunk +31 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
4 years, 6 months ago (2016-06-20 16:48:29 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-21 23:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073193003/20001
4 years, 6 months ago (2016-06-22 16:32:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 17:47:19 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:50:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/550547d0385f1cb8a905d4322a7ae7452a0d3e7b
Cr-Commit-Position: refs/heads/master@{#401337}

Powered by Google App Engine
This is Rietveld 408576698