Issue 2077020: Revert 48042: it breaks unit-tests and UI tests on ChromeOS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2077020: Revert 48042: it breaks unit-tests and UI tests on ChromeOS... (Closed)

Created:
10 years, 7 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 48042: it breaks unit-tests and UI tests on ChromeOS Disabling app launcher and enabling apps by default on ChromeOS . BUG=3218 TEST=Open the new tab, the new new tab should be shown. Any installed app should be showing in there. Review URL: http://codereview.chromium.org/2135011 [email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48044

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -31 lines)			Patch
M	chrome/browser/browser.cc	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/defaults.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/defaults.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/test/in_process_browser_test.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)