Simplify FRAMEBUFFER_SRGB setting update.

Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0ed71926ff337965bef62feeaaca45e4a15fd05a
Cr-Commit-Position: refs/heads/master@{#401496}

[Zhenyao Mo, 2016-06-22 21:37:43]

Description was changed from

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
==========

to

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-06-22 21:38:38]

The CQ bit was checked by [email protected] to run a CQ dry run

[Zhenyao Mo, 2016-06-22 21:40:08]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 21:40:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083013006/20001

[Zhenyao Mo, 2016-06-22 21:40:50]

piman: Please take a look at both CL1 and CL2 and let me know which one you feel
is better.

qiankun: FYI

[piman, 2016-06-22 21:51:51]

LGTM on PS2. Doing an extra GL call on every draw call seems way too high a
cost.

[commit-bot: I haz the power, 2016-06-23 00:28:11]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-06-23 00:28:12]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Zhenyao Mo, 2016-06-23 00:33:25]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-06-23 00:34:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083013006/20001

[Zhenyao Mo, 2016-06-23 01:12:47]

The CQ bit was unchecked by [email protected]

[Zhenyao Mo, 2016-06-23 01:13:26]

mac_optional_gpu times out and is unrelated to this CL.

Land with NOTRY=true

[Zhenyao Mo, 2016-06-23 01:13:39]

Description was changed from

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-06-23 01:13:55]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-06-23 01:14:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083013006/20001

[commit-bot: I haz the power, 2016-06-23 01:19:12]

Description was changed from

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-23 01:19:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-23 01:21:07]

Description was changed from

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Simplify FRAMEBUFFER_SRGB setting update.

Before we tracked its state and only call glEnable/glDIsable when it's
actually changed.

This caused a bug where virtual context is used on Linux.

This CL simplified the handling by not tracking its state and always
call glEnable/glDisable at render time.

BUG=540900
TEST=fbomultisample.html on linux does not cause flashing
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0ed71926ff337965bef62feeaaca45e4a15fd05a
Cr-Commit-Position: refs/heads/master@{#401496}
==========

[commit-bot: I haz the power, 2016-06-23 01:21:09]

Patchset 2 (id:??) landed as
https://crrev.com/0ed71926ff337965bef62feeaaca45e4a15fd05a
Cr-Commit-Position: refs/heads/master@{#401496}