Issue 208683002: Don't cache non-redirect HTTP responses when a redirect is forced

Issue 208683002: Don't cache non-redirect HTTP responses when a redirect is forced (Closed)

Created:
6 years, 9 months ago by mmenke

Modified:
6 years, 9 months ago

Reviewers:
davidben

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, robwu

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Don't cache non-redirect HTTP responses when a redirect is forced by a NetworkDelegate in OnHeadersReceived. This regressed in https://chromiumcodereview.appspot.com/23710059. Fortunately, no NetworkDelegate currently does this, but that is going to change. BUG=354508 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258983

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -8 lines)			Patch
A	net/data/url_request_unittest/redirect302-to-echo-cacheable	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	net/data/url_request_unittest/redirect302-to-echo-cacheable.mock-http-headers	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/http/http_cache_transaction.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/http/http_transaction_unittest.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/http/http_transaction_unittest.cc	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	net/url_request/url_request_http_job.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View	1 chunk	+20 lines, -1 line	0 comments	Download
M	net/url_request/url_request_job.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_job.cc	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	net/url_request/url_request_job_unittest.cc	View	3 chunks	+26 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_test_util.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_test_util.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	2 chunks	+72 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

mmenke

On 2014/03/24 16:41:46, David Benjamin wrote: > lgtm Thanks!

6 years, 9 months ago (2014-03-24 16:43:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/208683002/1

6 years, 9 months ago (2014-03-24 16:43:36 UTC) #5

Message was sent while issue was closed.

Change committed as 258983