Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2087163003: Remove calls to deprecated MessageLoop methods in ipc. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in ipc. This CL makes the following replacements in ipc: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 [email protected] Committed: https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8 Cr-Commit-Position: refs/heads/master@{#401385}

Patch Set 1 #

Patch Set 2 : manual changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -51 lines) Patch
M ipc/attachment_broker_mac_unittest.cc View 16 chunks +19 lines, -18 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 5 chunks +5 lines, -4 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 17:41:34 UTC) #1
jam
lgtm
4 years, 6 months ago (2016-06-22 19:30:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087163003/20001
4 years, 6 months ago (2016-06-22 19:50:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 19:56:39 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 20:00:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8
Cr-Commit-Position: refs/heads/master@{#401385}

Powered by Google App Engine
This is Rietveld 408576698