Issue 21038006: cc: Prevent vector finds that are not needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21038006: cc: Prevent vector finds that are not needed. (Closed)

Created:
7 years, 4 months ago by danakj

Modified:
7 years, 4 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, brianderson_google, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

cc: Prevent vector finds that are not needed. The caller knows if it was in the vector of layers with copy requests already or not, since it knows if it had copy requests already or not. So have the LayerImpl only add itself to the list if it's not in the list. [email protected] BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214442

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	cc/layers/layer_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	cc/trees/layer_tree_impl.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/21038006/1

7 years, 4 months ago (2013-07-30 21:11:03 UTC) #3

danakj

7 years, 4 months ago (2013-07-30 22:27:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r214442 (presubmit successful).