Issue 213833006: Empty rects don't bleed

Issue 213833006: Empty rects don't bleed (Closed)

Created:
6 years, 8 months ago by pdr.

Modified:
6 years, 8 months ago

Reviewers:
Stephen Chennney

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Empty rects don't bleed This is a trivial patch to not inflate empty rects for bleed avoidance. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170448

Patch Set 1 #

Patch Set 2 : Blank png is platform-specific #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/stroke/empty-path.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/stroke/empty-path-expected.png	View		Binary file		0 comments	Download
A	LayoutTests/svg/stroke/empty-path-expected.txt	View		1 chunk	+8 lines, -0 lines	1 comment	Download
M	Source/core/rendering/svg/RenderSVGShape.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pdr.

https://codereview.chromium.org/213833006/diff/20001/LayoutTests/svg/stroke/empty-path-expected.txt File LayoutTests/svg/stroke/empty-path-expected.txt (right): https://codereview.chromium.org/213833006/diff/20001/LayoutTests/svg/stroke/empty-path-expected.txt#newcode6 LayoutTests/svg/stroke/empty-path-expected.txt:6: RenderSVGRoot {svg} at (8,8) size 0x0 without this patch, ...

6 years, 8 months ago (2014-03-30 03:20:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/213833006/20001

6 years, 8 months ago (2014-03-31 13:53:12 UTC) #4

Message was sent while issue was closed.

Change committed as 170448

Expand Messages | Collapse Messages