Add some words of caution to File::Flush().

Add some words of caution to File::Flush().

Document latency percentiles.

BUG=473337
Committed: https://crrev.com/301e81e8f7a5dde6e20359905852a8d92bbaae92
Cr-Commit-Position: refs/heads/master@{#407305}

[Thiemo Nagel, 2016-07-21 17:11:52]

[email protected] changed reviewers:
+ [email protected]

[Thiemo Nagel, 2016-07-21 17:11:53]

Hi Dana,

could you please take a look at this comment-only change?

BTW, now that the statistics have been gathered, we could either remove the
PlatformFile.FlushTime histogram or keep it to update the stats from time to
time.  What do you think?

Thank you,
Thiemo

[danakj, 2016-07-21 18:43:29]

If no one will be looking at the histrogram anymore let's remove it.

[Thiemo Nagel, 2016-07-21 20:01:12]

On 2016/07/21 18:43:29, danakj wrote:
> If no one will be looking at the histrogram anymore let's remove it.

I don't think that anyone but me looks at that histogram.  Thus let me rephrase:
Would you see value in having that comment updated from time to time (eg.
yearly)?

Thank you,
Thiemo

[danakj, 2016-07-21 20:51:22]

On Thu, Jul 21, 2016 at 1:01 PM, <[email protected]> wrote:

> On 2016/07/21 18:43:29, danakj wrote:
> > If no one will be looking at the histrogram anymore let's remove it.
>
> I don't think that anyone but me looks at that histogram. Thus let me
> rephrase:
> Would you see value in having that comment updated from time to time (eg.
> yearly)?
>

Eh, do you think it's going to change significantly? I think the point is
well made that it can take many seconds. I wouldnt expect that to be
different next year in a meaningful way, would you?


>
> Thank you,
> Thiemo
>
> https://codereview.chromium.org/2171833002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].

[Thiemo Nagel, 2016-07-22 09:31:23]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:31:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 11:10:52]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-07-22 11:10:53]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2016-07-22 11:47:42]

On 2016/07/21 20:51:22, danakj wrote:
> Eh, do you think it's going to change significantly? I think the point is
> well made that it can take many seconds. I wouldnt expect that to be
> different next year in a meaningful way, would you?

I was afraid that someone might discount the stats as being out-of-date at some
point in the future, but I guess you're right.  The point is made, and devs that
chose to ignore it won't be stopped by updated stats either.

Could you please take another look?

[Thiemo Nagel, 2016-07-22 11:48:36]

[email protected] changed reviewers:
+ [email protected]
- [email protected]

[Thiemo Nagel, 2016-07-22 11:48:36]

isherman, could you ptal at histograms.xml?

[Thiemo Nagel, 2016-07-22 11:48:56]

Description was changed from

==========
Add some words of caution to base::Flush().

Document latency percentiles.

BUG=473337
==========

to

==========
Add some words of caution to base::Flush().

Document latency percentiles.

BUG=473337
==========

[Thiemo Nagel, 2016-07-22 11:48:56]

[email protected] changed reviewers:
+ [email protected]

[Ilya Sherman, 2016-07-22 17:21:34]

https://codereview.chromium.org/2171833002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2171833002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:40924: -</histogram>
Please mark this histogram as <obsolete> rather than removing it from
histograms.xml.

[Thiemo Nagel, 2016-07-22 17:42:47]

Description was changed from

==========
Add some words of caution to base::Flush().

Document latency percentiles.

BUG=473337
==========

to

==========
Add some words of caution to File::Flush().

Document latency percentiles.

BUG=473337
==========

[Thiemo Nagel, 2016-07-22 17:45:45]

Thank you, Ilya.  Could you please take another look?

https://codereview.chromium.org/2171833002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2171833002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:40924: -</histogram>
On 2016/07/22 17:21:34, Ilya Sherman wrote:
> Please mark this histogram as <obsolete> rather than removing it from
> histograms.xml.

Done.

[Ilya Sherman, 2016-07-22 18:12:22]

histograms.xml lgtm

[danakj, 2016-07-22 18:56:19]

LGTM

[Thiemo Nagel, 2016-07-22 18:56:56]

On 2016/07/22 18:56:19, danakj wrote:
> LGTM

Thank you both!

[Thiemo Nagel, 2016-07-22 18:57:01]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-07-22 18:57:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 22:24:10]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-07-22 22:24:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Thiemo Nagel, 2016-07-22 22:30:19]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-07-22 22:31:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 23:55:36]

Description was changed from

==========
Add some words of caution to File::Flush().

Document latency percentiles.

BUG=473337
==========

to

==========
Add some words of caution to File::Flush().

Document latency percentiles.

BUG=473337
==========

[commit-bot: I haz the power, 2016-07-22 23:55:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 23:56:52]

Description was changed from

==========
Add some words of caution to File::Flush().

Document latency percentiles.

BUG=473337
==========

to

==========
Add some words of caution to File::Flush().

Document latency percentiles.

BUG=473337

Committed: https://crrev.com/301e81e8f7a5dde6e20359905852a8d92bbaae92
Cr-Commit-Position: refs/heads/master@{#407305}
==========

[commit-bot: I haz the power, 2016-07-22 23:56:54]

Patchset 3 (id:??) landed as
https://crrev.com/301e81e8f7a5dde6e20359905852a8d92bbaae92
Cr-Commit-Position: refs/heads/master@{#407305}