Revert of current program can be null in ES2/ES3 contexts.

Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001 of https://codereview.chromium.org/2174173002/ )

Reason for revert:
Caused webkit test failure on WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6624

unexpected_failures:
printing/webgl-oversized-printing.html
virtual/threaded/printing/webgl-oversized-printing.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/6624/layout-test-results/results.html

---
--- E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
+++ E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

---
--- E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
+++ E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

Original issue's description:
> current program can be null in ES2/ES3 contexts.
>
> They are only required to be non null in WebGL.
>
> This also did some clean up and a minor optimization.
>
> BUG=630802
> TEST=fuzzer case in the bug
> [email protected]
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> Cr-Commit-Position: refs/heads/master@{#407659}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802
Committed: https://crrev.com/e9c2cd979c8114b75bbc2640a43a1371d64f502b
Cr-Commit-Position: refs/heads/master@{#407711}

[Mark P, 2016-07-26 04:43:05]

The CQ bit was checked by [email protected]

[Mark P, 2016-07-26 04:43:06]

Created Revert of current program can be null in ES2/ES3 contexts.

[commit-bot: I haz the power, 2016-07-26 04:43:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 04:44:05]

Description was changed from

==========
Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001
of https://codereview.chromium.org/2174173002/ )

Reason for revert:
Caused webkit test failure on WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

unexpected_failures:
printing/webgl-oversized-printing.html
virtual/threaded/printing/webgl-oversized-printing.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg...

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.
 
 TEST COMPLETE
-PASS Printed without crashing.
---

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.
 
 TEST COMPLETE
-PASS Printed without crashing.
---


Original issue's description:
> current program can be null in ES2/ES3 contexts.
> 
> They are only required to be non null in WebGL.
> 
> This also did some clean up and a minor optimization.
> 
> BUG=630802
> TEST=fuzzer case in the bug
> [email protected]
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> Cr-Commit-Position: refs/heads/master@{#407659}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802
==========

to

==========
Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001
of https://codereview.chromium.org/2174173002/ )

Reason for revert:
Caused webkit test failure on WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

unexpected_failures:
printing/webgl-oversized-printing.html
virtual/threaded/printing/webgl-oversized-printing.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg...

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.
 
 TEST COMPLETE
-PASS Printed without crashing.
---

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.
 
 TEST COMPLETE
-PASS Printed without crashing.
---


Original issue's description:
> current program can be null in ES2/ES3 contexts.
> 
> They are only required to be non null in WebGL.
> 
> This also did some clean up and a minor optimization.
> 
> BUG=630802
> TEST=fuzzer case in the bug
> [email protected]
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> Cr-Commit-Position: refs/heads/master@{#407659}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802
==========

[commit-bot: I haz the power, 2016-07-26 04:44:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-26 04:46:52]

Description was changed from

==========
Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001
of https://codereview.chromium.org/2174173002/ )

Reason for revert:
Caused webkit test failure on WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

unexpected_failures:
printing/webgl-oversized-printing.html
virtual/threaded/printing/webgl-oversized-printing.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg...

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.
 
 TEST COMPLETE
-PASS Printed without crashing.
---

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.
 
 TEST COMPLETE
-PASS Printed without crashing.
---


Original issue's description:
> current program can be null in ES2/ES3 contexts.
> 
> They are only required to be non null in WebGL.
> 
> This also did some clean up and a minor optimization.
> 
> BUG=630802
> TEST=fuzzer case in the bug
> [email protected]
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> Cr-Commit-Position: refs/heads/master@{#407659}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802
==========

to

==========
Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001
of https://codereview.chromium.org/2174173002/ )

Reason for revert:
Caused webkit test failure on WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

unexpected_failures:
printing/webgl-oversized-printing.html
virtual/threaded/printing/webgl-oversized-printing.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg...

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

---
---
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
+++
E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor'
of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

Original issue's description:
> current program can be null in ES2/ES3 contexts.
>
> They are only required to be non null in WebGL.
>
> This also did some clean up and a minor optimization.
>
> BUG=630802
> TEST=fuzzer case in the bug
> [email protected]
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> Cr-Commit-Position: refs/heads/master@{#407659}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802

Committed: https://crrev.com/e9c2cd979c8114b75bbc2640a43a1371d64f502b
Cr-Commit-Position: refs/heads/master@{#407711}
==========

[commit-bot: I haz the power, 2016-07-26 04:46:52]

Patchset 1 (id:??) landed as
https://crrev.com/e9c2cd979c8114b75bbc2640a43a1371d64f502b
Cr-Commit-Position: refs/heads/master@{#407711}

[Zhenyao Mo, 2016-07-26 04:50:15]

Are you sure it's caused by this CL?  This CL affects WebGL2, which is still
behind a flag. The failing tests are WebGL1.

[Mark P, 2016-07-26 05:03:17]

On 2016/07/26 04:50:15, Zhenyao Mo wrote:
> Are you sure it's caused by this CL?  This CL affects WebGL2, which is still
> behind a flag. The failing tests are WebGL1.

I was not aware of the different webgls.  All I noticed was
1) something that touches webgl  (the only thing that seemed like it touched
webgl)
2) errors in tests that involve webgl
3) a changelist description that says something about things being non-null in
webgl
4) errors about something in a webgl test that is now null

Apologies if I reverted wrongly.  Please monitor the bots and resubmit if they
look fine.
(I'm going to sleep.)

In retrospect, it appears from the flakiness dashboard that both these tests are
flaky on this bot.  They should probably be disabled.  If I wasn't trying to
tidy things up before bed, it probably would've been a better idea to watch the
bot and wait to see if it magically fixed itself.

--mark

[Zhenyao Mo, 2016-07-26 05:08:35]

On 2016/07/26 05:03:17, Mark P (no metrics til 7-26) wrote:
> On 2016/07/26 04:50:15, Zhenyao Mo wrote:
> > Are you sure it's caused by this CL?  This CL affects WebGL2, which is still
> > behind a flag. The failing tests are WebGL1.
> 
> I was not aware of the different webgls.  All I noticed was
> 1) something that touches webgl  (the only thing that seemed like it touched
> webgl)
> 2) errors in tests that involve webgl
> 3) a changelist description that says something about things being non-null in
> webgl
> 4) errors about something in a webgl test that is now null
> 
> Apologies if I reverted wrongly.  Please monitor the bots and resubmit if they
> look fine.
> (I'm going to sleep.)
> 
> In retrospect, it appears from the flakiness dashboard that both these tests
are
> flaky on this bot.  They should probably be disabled.  If I wasn't trying to
> tidy things up before bed, it probably would've been a better idea to watch
the
> bot and wait to see if it magically fixed itself.
> 
> --mark

I created crbug.com/631316 to track this.  Relanding this CL because I am pretty
sure it's not the cause.

[Zhenyao Mo, 2016-07-26 05:09:12]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2186473002/ by [email protected].

The reason for reverting is: I don't think this is related.  See
crbug.com/631316 and here the conversion between me and Mark..