Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2196623003: Add check for mismatching item and document sequence numbers. (Closed)

Created:
4 years, 4 months ago by nasko
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add check for mismatching item and document sequence numbers. When a PageState update is received from the renderer process, it must be for the current session history entry. This means that the sequence numbers associated with the FrameNavigationEntry should match the ones coming from the renderer process. This CL adds a check for this case and drops the update if mismatch is found. BUG=628677 Committed: https://crrev.com/3463467767b4dbd5b0e52a1a0001cd6fb8288be4 Cr-Commit-Position: refs/heads/master@{#408698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
nasko
Hey Charlie, Can you review this CL for me? It is a split from https://codereview.chromium.org/2191543003/ ...
4 years, 4 months ago (2016-07-29 17:42:39 UTC) #2
Charlie Reis
LGTM
4 years, 4 months ago (2016-07-29 17:44:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196623003/1
4 years, 4 months ago (2016-07-29 17:46:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 18:46:20 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 18:47:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3463467767b4dbd5b0e52a1a0001cd6fb8288be4
Cr-Commit-Position: refs/heads/master@{#408698}

Powered by Google App Engine
This is Rietveld 408576698