Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2201163003: [Autofill] Autofill CC signin promo: flag for all platforms. (Closed)

Created:
4 years, 4 months ago by Mathieu
Modified:
4 years, 4 months ago
Reviewers:
sebsg
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Autofill CC signin promo: flag for all platforms. Made a mistake, should be available to all platforms. BUG=626442 TEST=manual Committed: https://crrev.com/8a74a9962ef4361dbd4a35152891d668ac6418ad Cr-Commit-Position: refs/heads/master@{#409524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mathieu
Hi, PTAL, Thanks!
4 years, 4 months ago (2016-08-02 21:35:49 UTC) #5
sebsg
lgtm
4 years, 4 months ago (2016-08-03 15:32:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201163003/1
4 years, 4 months ago (2016-08-03 15:32:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 16:21:36 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 16:23:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a74a9962ef4361dbd4a35152891d668ac6418ad
Cr-Commit-Position: refs/heads/master@{#409524}

Powered by Google App Engine
This is Rietveld 408576698