Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2272653004: ImageCapture - PhotoCapabilities.java: add an inner Builder class (Closed)

Created:
4 years, 3 months ago by mcasas
Modified:
4 years, 3 months ago
Reviewers:
Sami
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, blink-reviews, alokp+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageCapture - PhotoCapabilities.java: add an inner Builder class Cleanup: PhotoCapabilities is starting to have too many parameters, so this CL adds a builder for it. BUG=518807 Committed: https://crrev.com/a0b90fd7039b12e8c8fc2d15a81b7139a1a41b0f Cr-Commit-Position: refs/heads/master@{#414438}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -13 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java View 2 chunks +95 lines, -1 line 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java View 5 chunks +11 lines, -6 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 6 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
mcasas
skyostil@ small refactor, PTAL
4 years, 3 months ago (2016-08-25 04:37:16 UTC) #11
Sami
lgtm, thanks for the cleanup.
4 years, 3 months ago (2016-08-25 09:22:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272653004/140001
4 years, 3 months ago (2016-08-25 13:32:34 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:140001)
4 years, 3 months ago (2016-08-25 15:05:31 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 15:09:13 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0b90fd7039b12e8c8fc2d15a81b7139a1a41b0f
Cr-Commit-Position: refs/heads/master@{#414438}

Powered by Google App Engine
This is Rietveld 408576698