Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2275643002:
[DevTools] inspector tests are slow on debug bots (Closed)
Description[DevTools] Masrk virtual/asyncawait/inspector as slow
Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW.
I'll mark it as timeout if it won't help.
BUG=636835, 621515
NOTRY=true
[email protected]
Committed: https://crrev.com/4eabc22ef76859401193b8ff870b5a4b429661f9
Cr-Commit-Position: refs/heads/master@{#413811}
Patch Set 1 #
Total comments: 2
Patch Set 2 : mark as slow on all bots #
Total comments: 2
Patch Set 3 : remove redundadnt line break #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== [DevTools] inspector tests are slow on debug bots Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=634019 ========== to ========== [DevTools] inspector tests are slow on debug bots Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=636835, 621515 NOTRY=true [email protected] ==========
[email protected] changed reviewers: + [email protected], [email protected], [email protected]
The CQ bit was checked by [email protected]
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2275643002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/SlowTests (right): https://codereview.chromium.org/2275643002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/SlowTests:99: webkit.org/b/90488 [ Debug ] virtual/asyncawait/inspector/sources/debugger-async/ [ Slow ] Is it enough to make only the debug ones Slow? I think we want it to always be Slow.
The CQ bit was unchecked by [email protected]
Description was changed from ========== [DevTools] inspector tests are slow on debug bots Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=636835, 621515 NOTRY=true [email protected] ========== to ========== [DevTools] Masrk virtual/asyncawait/inspector as slow Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=636835, 621515 NOTRY=true [email protected] ==========
The CQ bit was checked by [email protected]
lgtm https://codereview.chromium.org/2275643002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/SlowTests (right): https://codereview.chromium.org/2275643002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/SlowTests:99: Why the line break?
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2275643002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/SlowTests (right): https://codereview.chromium.org/2275643002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/SlowTests:99: webkit.org/b/90488 [ Debug ] virtual/asyncawait/inspector/sources/debugger-async/ [ Slow ] On 2016/08/23 19:00:23, Dan Ehrenberg wrote: > Is it enough to make only the debug ones Slow? I think we want it to always be > Slow. Good catch, not enough, based on [1] these are mostly slow on debug, and on win_chromium_rel_ng. Let's mark them as SLOW on all bots as other inspector debugger tests. [1] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=vir...
The CQ bit was unchecked by [email protected]
Thanks, done. https://codereview.chromium.org/2275643002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/SlowTests (right): https://codereview.chromium.org/2275643002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/SlowTests:99: On 2016/08/23 19:08:39, Dan Ehrenberg wrote: > Why the line break? Removed.
The CQ bit was checked by [email protected]
The patchset sent to the CQ was uploaded after l-g-t-m from [email protected] Link to the patchset: https://codereview.chromium.org/2275643002/#ps40001 (title: "remove redundadnt line break")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Masrk virtual/asyncawait/inspector as slow Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=636835, 621515 NOTRY=true [email protected] ========== to ========== [DevTools] Masrk virtual/asyncawait/inspector as slow Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=636835, 621515 NOTRY=true [email protected] ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Masrk virtual/asyncawait/inspector as slow Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=636835, 621515 NOTRY=true [email protected] ========== to ========== [DevTools] Masrk virtual/asyncawait/inspector as slow Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW. I'll mark it as timeout if it won't help. BUG=636835, 621515 NOTRY=true [email protected] Committed: https://crrev.com/4eabc22ef76859401193b8ff870b5a4b429661f9 Cr-Commit-Position: refs/heads/master@{#413811} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4eabc22ef76859401193b8ff870b5a4b429661f9 Cr-Commit-Position: refs/heads/master@{#413811} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
