Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 228653007: Move DispatchBeforeUnload from RenderFrameHost to WebContents. This is after discussions to move as… (Closed)

Created:
6 years, 8 months ago by jam
Modified:
6 years, 8 months ago
Reviewers:
Charlie Reis, lushnikov
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, vsevik, creis+watch_chromium.org, tburkard+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, yurys, gavinp+prer_chromium.org, dominich+watch_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Move DispatchBeforeUnload from RenderFrameHost to WebContents. This is after discussions to move as much stuff as possible to WebContents. BUG=304341 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -72 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fast_unload_controller.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/unload_controller.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +43 lines, -43 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
6 years, 8 months ago (2014-04-08 20:54:08 UTC) #1
Charlie Reis
6 years, 8 months ago (2014-04-08 21:31:47 UTC) #2
Yep, exposing just the top-level one makes sense, as long as we can still run it
on subframes within content.  LGTM!

Powered by Google App Engine
This is Rietveld 408576698