Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 2298523002: Remove chrome utility GYP integration. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome utility GYP integration. Inline the sources in the GN build. [email protected] Committed: https://crrev.com/e070330fe0cbf64edecce973462b943995c31b73 Cr-Commit-Position: refs/heads/master@{#415437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -275 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/chrome_utility.gypi View 1 chunk +0 lines, -255 lines 0 comments Download
M chrome/utility/BUILD.gn View 6 chunks +97 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
4 years, 3 months ago (2016-08-30 20:29:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298523002/1
4 years, 3 months ago (2016-08-30 20:30:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:41:07 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e070330fe0cbf64edecce973462b943995c31b73 Cr-Commit-Position: refs/heads/master@{#415437}
4 years, 3 months ago (2016-08-30 21:43:36 UTC) #6
Dirk Pranke
4 years, 3 months ago (2016-08-31 04:40:23 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698