Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

The notifications from ResourceDispatcherHostImpl to WebContents were using a RenderFrameHost ID to find the WebContents. Switch it to using the WebContentsGetter. The only issue I ran into was that calculating the data for the LoadStateChanged callback correctly meant that it had to be done on teh UI thread (so that we can compare navigation requests with subresource requests). Since RDH has to hop to the UI thread to calculate this, there's no point to hopping back to the IO thread to call its delegate which would then hop back to the UI thread, so I changed the delegate method to be called on the UI thread.

BUG=504347
Committed: https://crrev.com/73f8926484f8e12b1348e6daecaa198f8336956a
Cr-Commit-Position: refs/heads/master@{#417855}

[jam, 2016-09-09 20:38:04]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 20:38:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-09 20:40:32]

Description was changed from

==========
Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

The notifications from ResourceDispatcherHostImpl to WebContents were using a
RenderFrameHost ID to find the WebContents. Switch it to using the
WebContentsGetter. The only issue I ran into was that calculating the data for
the LoadStateChanged callback correctly meant that it had to be done on teh UI
thread (so that we can compare navigation requests with subresource requests).
Since RDH has to hop to the UI thread to calculate this, there's no point to
hopping back to the IO thread to call its delegate which would then hop back to
the UI thread, so I changed the delegate method to be called on the UI thread.

BUG=504347
==========

to

==========
Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

The notifications from ResourceDispatcherHostImpl to WebContents were using a
RenderFrameHost ID to find the WebContents. Switch it to using the
WebContentsGetter. The only issue I ran into was that calculating the data for
the LoadStateChanged callback correctly meant that it had to be done on teh UI
thread (so that we can compare navigation requests with subresource requests).
Since RDH has to hop to the UI thread to calculate this, there's no point to
hopping back to the IO thread to call its delegate which would then hop back to
the UI thread, so I changed the delegate method to be called on the UI thread.

BUG=504347
==========

[jam, 2016-09-09 20:40:32]

[email protected] changed reviewers:
+ [email protected]

[commit-bot: I haz the power, 2016-09-09 20:58:11]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-09 20:58:12]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[jam, 2016-09-09 23:48:16]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 23:48:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 00:06:45]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-10 00:06:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottmg, 2016-09-10 00:14:36]

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
content/browser/loader/resource_dispatcher_host_impl.cc:2419:
std::unique_ptr<ResourceDispatcherHostImpl::LoadInfoMap>
// static

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
File content/browser/loader/resource_dispatcher_host_unittest.cc (right):

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
content/browser/loader/resource_dispatcher_host_unittest.cc:3424: WebContents*
wc1 = reinterpret_cast<WebContents*>(0x1);
This is kind of weird. Can you just WebContents::Create(CreateParams(nullptr))
into a unique_ptr here instead?

[jam, 2016-09-10 00:16:23]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:16:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-10 00:24:15]

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
content/browser/loader/resource_dispatcher_host_impl.cc:2419:
std::unique_ptr<ResourceDispatcherHostImpl::LoadInfoMap>
On 2016/09/10 00:14:35, scottmg wrote:
> // static

Done.

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
File content/browser/loader/resource_dispatcher_host_unittest.cc (right):

https://codereview.chromium.org/2327163002/diff/20001/content/browser/loader/...
content/browser/loader/resource_dispatcher_host_unittest.cc:3424: WebContents*
wc1 = reinterpret_cast<WebContents*>(0x1);
On 2016/09/10 00:14:35, scottmg wrote:
> This is kind of weird. Can you just WebContents::Create(CreateParams(nullptr))
> into a unique_ptr here instead?

creating a WC is actually pretty heavyweight (i.e. generally need
BrowserContext, SiteInstance and who knows what else through all the various
constructors and destructors of members of each). So since it's only used as a
key value, I think this is fine. Since it's a test, if anything breaks it'll be
obvious quickly.

[jam, 2016-09-10 00:25:13]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:25:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-10 00:32:37]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:33:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-09-10 00:48:09]

lgtm

[commit-bot: I haz the power, 2016-09-10 02:31:10]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-10 02:31:11]

Dry run: This issue passed the CQ dry run.

[jam, 2016-09-11 04:40:55]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-09-11 04:41:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-11 06:04:25]

Description was changed from

==========
Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

The notifications from ResourceDispatcherHostImpl to WebContents were using a
RenderFrameHost ID to find the WebContents. Switch it to using the
WebContentsGetter. The only issue I ran into was that calculating the data for
the LoadStateChanged callback correctly meant that it had to be done on teh UI
thread (so that we can compare navigation requests with subresource requests).
Since RDH has to hop to the UI thread to calculate this, there's no point to
hopping back to the IO thread to call its delegate which would then hop back to
the UI thread, so I changed the delegate method to be called on the UI thread.

BUG=504347
==========

to

==========
Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

The notifications from ResourceDispatcherHostImpl to WebContents were using a
RenderFrameHost ID to find the WebContents. Switch it to using the
WebContentsGetter. The only issue I ran into was that calculating the data for
the LoadStateChanged callback correctly meant that it had to be done on teh UI
thread (so that we can compare navigation requests with subresource requests).
Since RDH has to hop to the UI thread to calculate this, there's no point to
hopping back to the IO thread to call its delegate which would then hop back to
the UI thread, so I changed the delegate method to be called on the UI thread.

BUG=504347
==========

[commit-bot: I haz the power, 2016-09-11 06:04:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-11 06:06:30]

Description was changed from

==========
Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

The notifications from ResourceDispatcherHostImpl to WebContents were using a
RenderFrameHost ID to find the WebContents. Switch it to using the
WebContentsGetter. The only issue I ran into was that calculating the data for
the LoadStateChanged callback correctly meant that it had to be done on teh UI
thread (so that we can compare navigation requests with subresource requests).
Since RDH has to hop to the UI thread to calculate this, there's no point to
hopping back to the IO thread to call its delegate which would then hop back to
the UI thread, so I changed the delegate method to be called on the UI thread.

BUG=504347
==========

to

==========
Fix SSLUITest.BadCertFollowedByGoodCert with PlzNavigate.

The notifications from ResourceDispatcherHostImpl to WebContents were using a
RenderFrameHost ID to find the WebContents. Switch it to using the
WebContentsGetter. The only issue I ran into was that calculating the data for
the LoadStateChanged callback correctly meant that it had to be done on teh UI
thread (so that we can compare navigation requests with subresource requests).
Since RDH has to hop to the UI thread to calculate this, there's no point to
hopping back to the IO thread to call its delegate which would then hop back to
the UI thread, so I changed the delegate method to be called on the UI thread.

BUG=504347

Committed: https://crrev.com/73f8926484f8e12b1348e6daecaa198f8336956a
Cr-Commit-Position: refs/heads/master@{#417855}
==========

[commit-bot: I haz the power, 2016-09-11 06:06:31]

Patchset 5 (id:??) landed as
https://crrev.com/73f8926484f8e12b1348e6daecaa198f8336956a
Cr-Commit-Position: refs/heads/master@{#417855}