Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock class of DiskMountMan…

Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.

Committed: https://crrev.com/cafadf5bd103b96c300eed6aad4244837d9f6b76
Cr-Commit-Position: refs/heads/master@{#418811}

[yamaguchi, 2016-09-15 03:40:10]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 03:40:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-09-15 03:59:12]

[email protected] changed reviewers:
+ [email protected]

[yamaguchi, 2016-09-15 03:59:13]

ptal.
I checked the error that happened with the original CL:
https://findit-for-me.appspot.com/waterfall/build-failure?url=https%3A%2F%2Fptop.only.wip.la%3A443%2Fhttps%2Fb...
was detected by local test with LeakSanitizer enabled, and it no longer happen
with patchset 2.

[yamaguchi, 2016-09-15 04:14:05]

Description was changed from

==========
Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock
class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest built and run with is_asan and is_lsan = true in gn args.
==========

to

==========
Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock
class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run
with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.
==========

[commit-bot: I haz the power, 2016-09-15 04:17:46]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-15 04:17:47]

Dry run: This issue passed the CQ dry run.

[satorux1, 2016-09-15 06:53:19]

lgtm

[yamaguchi, 2016-09-15 09:01:37]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-09-15 09:01:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 09:06:10]

Description was changed from

==========
Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock
class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run
with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.
==========

to

==========
Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock
class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run
with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.
==========

[commit-bot: I haz the power, 2016-09-15 09:06:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 09:07:43]

Description was changed from

==========
Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock
class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run
with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.
==========

to

==========
Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock
class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run
with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.

Committed: https://crrev.com/cafadf5bd103b96c300eed6aad4244837d9f6b76
Cr-Commit-Position: refs/heads/master@{#418811}
==========

[commit-bot: I haz the power, 2016-09-15 09:07:44]

Patchset 2 (id:??) landed as
https://crrev.com/cafadf5bd103b96c300eed6aad4244837d9f6b76
Cr-Commit-Position: refs/heads/master@{#418811}