Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2354973003: [DevTools] Move subtargets functionality from ServiceWorker to Target domain. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move subtargets functionality from ServiceWorker to Target domain. BUG=648775 Committed: https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a Cr-Commit-Position: refs/heads/master@{#421437}

Patch Set 1 #

Total comments: 4

Patch Set 2 : cleanup #

Patch Set 3 : context namer #

Patch Set 4 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+904 lines, -696 lines) Patch
M content/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/schema_handler.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.h View 3 chunks +2 lines, -28 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 2 3 10 chunks +7 lines, -234 lines 0 comments Download
A content/browser/devtools/protocol/target_handler.h View 1 chunk +77 lines, -0 lines 0 comments Download
A content/browser/devtools/protocol/target_handler.cc View 1 2 3 1 chunk +291 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 3 7 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 2 3 6 chunks +99 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 1 2 3 11 chunks +25 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 2 3 13 chunks +93 lines, -347 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 1 2 3 1 chunk +288 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-21 00:48:08 UTC) #3
pfeldman
lgtm https://codereview.chromium.org/2354973003/diff/1/content/browser/devtools/protocol/schema_handler.cc File content/browser/devtools/protocol/schema_handler.cc (right): https://codereview.chromium.org/2354973003/diff/1/content/browser/devtools/protocol/schema_handler.cc#newcode22 content/browser/devtools/protocol/schema_handler.cc:22: static const char* kDomains[] = { What is ...
4 years, 3 months ago (2016-09-22 00:34:09 UTC) #7
dgozman
https://codereview.chromium.org/2354973003/diff/1/content/browser/devtools/protocol/schema_handler.cc File content/browser/devtools/protocol/schema_handler.cc (right): https://codereview.chromium.org/2354973003/diff/1/content/browser/devtools/protocol/schema_handler.cc#newcode22 content/browser/devtools/protocol/schema_handler.cc:22: static const char* kDomains[] = { On 2016/09/22 00:34:09, ...
4 years, 2 months ago (2016-09-27 22:29:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354973003/60001
4 years, 2 months ago (2016-09-28 03:22:50 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-28 03:28:14 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 03:32:38 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a
Cr-Commit-Position: refs/heads/master@{#421437}

Powered by Google App Engine
This is Rietveld 408576698