Add an empty Android implementation of the PhysicalWebDataSource

Add an empty Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
Committed: https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5
Cr-Commit-Position: refs/heads/master@{#423754}

[mattreynolds, 2016-09-21 21:03:29]

Description was changed from

==========
Add an Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an initial
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
==========

to

==========
Add an Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an initial
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
==========

[mattreynolds, 2016-09-21 21:03:29]

[email protected] changed reviewers:
+ [email protected], [email protected]

[hayesjordan, 2016-09-22 21:23:29]

On 2016/09/21 21:03:29, mattreynolds wrote:
> mailto:[email protected] changed reviewers:
> + mailto:[email protected], mailto:[email protected]

lgtm

[cco3, 2016-09-26 21:59:25]

LGTM

(Might want to add in the description that the implementation is empty)

[mattreynolds, 2016-09-26 22:35:34]

Description was changed from

==========
Add an Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an initial
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
==========

to

==========
Add an empty Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
==========

[mattreynolds, 2016-09-26 22:36:13]

[email protected] changed reviewers:
+ [email protected]

[mattreynolds, 2016-09-26 22:36:14]

Hi Ben, PTAL

[Ben Goodger (Google), 2016-10-06 17:17:26]

On 2016/09/26 22:36:14, mattreynolds wrote:
> Hi Ben, PTAL

Hello - what are the intended dependencies of this code in src/chrome? What do
you intend to use it for? Is there a design doc?

[mattreynolds, 2016-10-06 22:28:21]

On 2016/10/06 17:17:26, Ben Goodger (Google) wrote:
> On 2016/09/26 22:36:14, mattreynolds wrote:
> > Hi Ben, PTAL
> 
> Hello - what are the intended dependencies of this code in src/chrome? What do
> you intend to use it for? Is there a design doc?

This is an offshoot of our work to add a Physical Web omnibox suggestion
provider in Chrome for iOS:

https://docs.google.com/document/d/1CXN2Dj3QtvLXobXcu--hBsKnWKN8BsOvo9dN9QlzZ...

The NTP content suggestions team is interested in showing Physical Web
suggestions on NTP in Chrome for Android, so we're adding an Android
implementation of the data source that will use a JNI bridge to get the list of
nearby URLs into the native layer.  They've already begun implementing their
provider, they are just waiting on us for the API:

https://cs.chromium.org/chromium/src/components/ntp_snippets/physical_web_pag...

As far as src/chrome dependencies, I'm not sure how they will implement it.  For
the omnibox provider, we needed to make the data source available through the
iOS-specific embedder (AutocompleteProviderClientImpl).  I'm not as familiar
with the ntp_snippets code but I assume they will do something similar that
makes sense for their component.

[Ben Goodger (Google), 2016-10-06 22:46:06]

On 2016/10/06 22:28:21, mattreynolds wrote:
> On 2016/10/06 17:17:26, Ben Goodger (Google) wrote:
> > On 2016/09/26 22:36:14, mattreynolds wrote:
> > > Hi Ben, PTAL
> > 
> > Hello - what are the intended dependencies of this code in src/chrome? What
do
> > you intend to use it for? Is there a design doc?
> 
> This is an offshoot of our work to add a Physical Web omnibox suggestion
> provider in Chrome for iOS:
> 
>
https://docs.google.com/document/d/1CXN2Dj3QtvLXobXcu--hBsKnWKN8BsOvo9dN9QlzZ...
> 
> The NTP content suggestions team is interested in showing Physical Web
> suggestions on NTP in Chrome for Android, so we're adding an Android
> implementation of the data source that will use a JNI bridge to get the list
of
> nearby URLs into the native layer.  They've already begun implementing their
> provider, they are just waiting on us for the API:
> 
>
https://cs.chromium.org/chromium/src/components/ntp_snippets/physical_web_pag...
> 
> As far as src/chrome dependencies, I'm not sure how they will implement it. 
For
> the omnibox provider, we needed to make the data source available through the
> iOS-specific embedder (AutocompleteProviderClientImpl).  I'm not as familiar
> with the ntp_snippets code but I assume they will do something similar that
> makes sense for their component.

Thanks for the update. This LGTM.

[mattreynolds, 2016-10-06 22:53:12]

The CQ bit was checked by [email protected]

[mattreynolds, 2016-10-06 22:53:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected]
Link to the patchset: https://codereview.chromium.org/2361603002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-06 22:53:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 00:17:26]

Description was changed from

==========
Add an empty Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
==========

to

==========
Add an empty Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
==========

[commit-bot: I haz the power, 2016-10-07 00:17:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 00:19:23]

Description was changed from

==========
Add an empty Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490
==========

to

==========
Add an empty Android implementation of the PhysicalWebDataSource

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490

Committed: https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5
Cr-Commit-Position: refs/heads/master@{#423754}
==========

[commit-bot: I haz the power, 2016-10-07 00:19:24]

Patchset 2 (id:??) landed as
https://crrev.com/f1aab392e8953a9ce8aa289a62ee157b59f629a5
Cr-Commit-Position: refs/heads/master@{#423754}