Move device_sensors cross-process headers out of //content

Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

The Blink headers referenced from these ones should also move to sit next
to these ones.

BUG=612322
Committed: https://crrev.com/b8138c3c83c74bd313d48f5bb0e90fbfd5e1ddc7
Cr-Commit-Position: refs/heads/master@{#424160}

[blundell, 2016-10-04 14:49:16]

Description was changed from

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

BUG=612322
==========

to

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

BUG=612322
==========

[blundell, 2016-10-04 14:49:34]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 14:49:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 14:53:42]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-04 14:53:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-10-04 14:57:40]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 14:57:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-10-04 14:58:39]

Description was changed from

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

BUG=612322
==========

to

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

Presumably the Blink headers referenced from these ones should move to
sit next to these ones.

BUG=612322
==========

[blundell, 2016-10-04 15:33:10]

Description was changed from

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

Presumably the Blink headers referenced from these ones should move to
sit next to these ones.

BUG=612322
==========

to

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

The Blink headers referenced from these ones should also move to sit next
to these ones.

BUG=612322
==========

[blundell, 2016-10-04 15:35:06]

[email protected] changed reviewers:
+ [email protected], [email protected]

[blundell, 2016-10-04 15:35:07]

Hi John and Tim,

Could you both review the whole CL please? Thanks!

[commit-bot: I haz the power, 2016-10-04 15:42:47]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-04 15:42:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[timvolodine, 2016-10-04 22:24:17]

On 2016/10/04 15:35:07, blundell wrote:
> Hi John and Tim,
> 
> Could you both review the whole CL please? Thanks!

magnifique! lgtm thanks.

[jam, 2016-10-04 22:57:21]

Can you explain how device/sensors/public/cpp will be used?
i.e. once the consumer is in blink directly which calls the mojom, why do we
need a client library for such a simple service?

[blundell, 2016-10-05 17:32:19]

On 2016/10/04 22:57:21, jam wrote:
> Can you explain how device/sensors/public/cpp will be used?
> i.e. once the consumer is in blink directly which calls the mojom, why do we
> need a client library for such a simple service?

These headers are used to interpret shared memory consistently across the device
sensors impl and client. The handle to shared memory is itself passed via Mojo.

[blundell, 2016-10-06 11:07:59]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 11:08:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 12:10:32]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-06 12:10:33]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-10-07 07:02:01]

On 2016/10/05 17:32:19, blundell wrote:
> On 2016/10/04 22:57:21, jam wrote:
> > Can you explain how device/sensors/public/cpp will be used?
> > i.e. once the consumer is in blink directly which calls the mojom, why do we
> > need a client library for such a simple service?
> 
> These headers are used to interpret shared memory consistently across the
device
> sensors impl and client. The handle to shared memory is itself passed via
Mojo.

jam@: ping

[jam, 2016-10-10 14:53:49]

lgtm

[blundell, 2016-10-10 15:06:50]

The CQ bit was checked by [email protected]

[blundell, 2016-10-10 15:06:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected]
Link to the patchset: https://codereview.chromium.org/2389963003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-10 15:06:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 16:05:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-10 16:07:52]

Description was changed from

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

The Blink headers referenced from these ones should also move to sit next
to these ones.

BUG=612322
==========

to

==========
Move device_sensors cross-process headers out of //content

In preparation for migrating the implementation of
//device/sensors/public/interfaces down from //content/browser
into //device, this CL moves the headers shared between that implementation
and its client from //content/common/device_sensors into
//device/sensors/public/cpp.

I have left these headers in the //content namespace for now as they're
widely used by code that will also move. I'll move their namespace in
one go together with the rest of the code that's moving.

The Blink headers referenced from these ones should also move to sit next
to these ones.

BUG=612322

Committed: https://crrev.com/b8138c3c83c74bd313d48f5bb0e90fbfd5e1ddc7
Cr-Commit-Position: refs/heads/master@{#424160}
==========

[commit-bot: I haz the power, 2016-10-10 16:07:53]

Patchset 4 (id:??) landed as
https://crrev.com/b8138c3c83c74bd313d48f5bb0e90fbfd5e1ddc7
Cr-Commit-Position: refs/heads/master@{#424160}