Issue 243573006: Fix that removes any receiver-reported revived packets from

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243573006: Fix that removes any receiver-reported revived packets from (Closed)

Created:
6 years, 8 months ago by ramant (doing other things)

Modified:
6 years, 8 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix that removes any receiver-reported revived packets from pending_retransmissions_ list at the sender, and a couple of other tiny code cleanups. Also enables LargePostFEC end_to_end test, which now passes for 10K runs. Fixes FEC-related bug where sender still tries to retransmit packet that has been indicated as revived by receiver. Also enables end_to_end FEC test. Merge internal change: 65092998 [email protected]

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -14 lines)			Patch
M	net/quic/quic_sent_packet_manager.cc	View	3 chunks	+16 lines, -12 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages