Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2449553002: Remove dead DocumentState metrics tracking code (Closed)

Created:
4 years, 1 month ago by Bryan McQuade
Modified:
4 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead DocumentState metrics tracking code In https://codereview.chromium.org/2437863005, page_load_histograms, which was the only consumer of this code, was removed. Now that the page_load_histograms code has been removed, this code can be removed as well. BUG=657993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8 Cr-Commit-Position: refs/heads/master@{#429646}

Patch Set 1 #

Patch Set 2 : simplify #

Patch Set 3 : remove dead code #

Patch Set 4 : remove more docstate code #

Patch Set 5 : fix test class #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -202 lines) Patch
M components/test_runner/web_frame_test_client.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M components/test_runner/web_frame_test_client.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M components/test_runner/web_frame_test_proxy.h View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/common/frame_messages.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/common/navigation_params.h View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M content/common/navigation_params.cc View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M content/public/renderer/document_state.h View 1 2 3 4 5 5 chunks +0 lines, -94 lines 0 comments Download
M content/public/renderer/document_state.cc View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 10 chunks +5 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 3 4 5 6 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
Bryan McQuade
jochen, PTAL for content/ and third_party/WebKit rbyers, PTAL for test_runner and third_party/WebKit Thanks!
4 years, 1 month ago (2016-11-02 21:58:17 UTC) #21
Rick Byers
On 2016/11/02 21:58:17, Bryan McQuade wrote: > jochen, PTAL for content/ and third_party/WebKit > rbyers, ...
4 years, 1 month ago (2016-11-02 22:10:27 UTC) #22
Bryan McQuade
tsepez, PTAL for content/common/frame_messages.h change. Thanks!
4 years, 1 month ago (2016-11-02 23:16:48 UTC) #26
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-03 11:53:23 UTC) #27
Tom Sepez
messages LGTM.
4 years, 1 month ago (2016-11-03 17:55:04 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449553002/140001
4 years, 1 month ago (2016-11-03 17:57:42 UTC) #30
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 1 month ago (2016-11-03 18:05:17 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:14:34 UTC) #33
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8
Cr-Commit-Position: refs/heads/master@{#429646}

Powered by Google App Engine
This is Rietveld 408576698