Description was changed from ========== Remove dead document_state metrics tracking code In https://codereview.chromium.org/2437863005, page_load_histograms, which ...
Description was changed from
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
BUG=657993
==========
to
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
Note that the remaining page load metrics in document_state continue
to be referenced from the GetCSI logic in loadtimes_extension_bindings.cc.
Removal of that code is tracked in bug 621512.
BUG=657993
==========
Bryan McQuade
Description was changed from ========== Remove dead document_state metrics tracking code In https://codereview.chromium.org/2437863005, page_load_histograms, which ...
Description was changed from
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
Note that the remaining page load metrics in document_state continue
to be referenced from the GetCSI logic in loadtimes_extension_bindings.cc.
Removal of that code is tracked in bug 621512.
BUG=657993
==========
to
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
Note that the remaining page load metrics in document_state continue
to be referenced from the GetCSI logic in loadtimes_extension_bindings.cc.
Removal of that code is tracked in crbug.com/621512.
BUG=657993
==========
Bryan McQuade
Description was changed from ========== Remove dead document_state metrics tracking code In https://codereview.chromium.org/2437863005, page_load_histograms, which ...
Description was changed from
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
Note that the remaining page load metrics in document_state continue
to be referenced from the GetCSI logic in loadtimes_extension_bindings.cc.
Removal of that code is tracked in crbug.com/621512.
BUG=657993
==========
to
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
Note that the remaining page load metrics in document_state continue
to be referenced from the GetCSI logic in loadtimes_extension_bindings.cc.
Removal of that code is tracked in crbug.com/621512.
BUG=657993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449553002/60001
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/262462)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449553002/80001
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/262475)
4 years, 1 month ago
(2016-10-28 20:00:05 UTC)
#11
Description was changed from ========== Remove dead document_state metrics tracking code In https://codereview.chromium.org/2437863005, page_load_histograms, which ...
4 years, 1 month ago
(2016-10-31 14:51:26 UTC)
#12
Description was changed from
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
Note that the remaining page load metrics in document_state continue
to be referenced from the GetCSI logic in loadtimes_extension_bindings.cc.
Removal of that code is tracked in crbug.com/621512.
BUG=657993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
to
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
BUG=657993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
Bryan McQuade
Description was changed from ========== Remove dead document_state metrics tracking code In https://codereview.chromium.org/2437863005, page_load_histograms, which ...
4 years, 1 month ago
(2016-10-31 18:43:59 UTC)
#13
Description was changed from
==========
Remove dead document_state metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
BUG=657993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
to
==========
Remove dead DocumentState metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
BUG=657993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449553002/120001
4 years, 1 month ago
(2016-11-02 18:08:40 UTC)
#15
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/156692)
4 years, 1 month ago
(2016-11-02 18:56:11 UTC)
#17
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449553002/140001
4 years, 1 month ago
(2016-11-02 20:41:43 UTC)
#19
jochen, PTAL for content/ and third_party/WebKit rbyers, PTAL for test_runner and third_party/WebKit Thanks!
4 years, 1 month ago
(2016-11-02 21:58:17 UTC)
#21
jochen, PTAL for content/ and third_party/WebKit
rbyers, PTAL for test_runner and third_party/WebKit
Thanks!
Rick Byers
On 2016/11/02 21:58:17, Bryan McQuade wrote: > jochen, PTAL for content/ and third_party/WebKit > rbyers, ...
4 years, 1 month ago
(2016-11-02 22:10:27 UTC)
#22
On 2016/11/02 21:58:17, Bryan McQuade wrote:
> jochen, PTAL for content/ and third_party/WebKit
> rbyers, PTAL for test_runner and third_party/WebKit
>
> Thanks!
test_runner and WebKit LGTM
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449553002/140001
4 years, 1 month ago
(2016-11-03 17:57:42 UTC)
#30
4 years, 1 month ago
(2016-11-03 18:05:17 UTC)
#31
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
commit-bot: I haz the power
Description was changed from ========== Remove dead DocumentState metrics tracking code In https://codereview.chromium.org/2437863005, page_load_histograms, which ...
4 years, 1 month ago
(2016-11-03 18:14:32 UTC)
#32
Message was sent while issue was closed.
Description was changed from
==========
Remove dead DocumentState metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
BUG=657993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
to
==========
Remove dead DocumentState metrics tracking code
In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.
BUG=657993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8
Cr-Commit-Position: refs/heads/master@{#429646}
==========
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8 Cr-Commit-Position: refs/heads/master@{#429646}
4 years, 1 month ago
(2016-11-03 18:14:34 UTC)
#33
Issue 2449553002: Remove dead DocumentState metrics tracking code
(Closed)
Created 4 years, 1 month ago by Bryan McQuade
Modified 4 years, 1 month ago
Reviewers: jochen (gone - plz use gerrit), Rick Byers, Tom Sepez
Base URL:
Comments: 0