Introduce chrome.bluetoothSocket API.

Introduce chrome.bluetoothSocket API.

This CL adds the initial function and object type definitions of the
chrome.bluetoothSocket API. This API will replace the socket-related
functions in the existing chrome.bluetooth API and is intended to
supply the Bluetooth Classic complement to the
chrome.bluetoothLowEnergy API.

Unlike the sockets API, there is no separation of client and server
because such separation is not clearly defined in Bluetooth profiles
either. It will not be uncommon for an application to attempt to make
a connection, and if it fails, fall back to listening instead, for
example.

All functions currently return an error when invoked.

BUG=349475, 364581
TBR=mkearney

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266362

[keybuk, 2014-04-22 13:01:13]

rpaquay, armansito: for /bluetooth/
mkearney: for /docs/
miket, kalman: for /api/

The intent here is to end up with:

 chrome.bluetooth - adapter state, device info, device discovery
  `- chrome.bluetoothLowEnergy - bluetooth le services
  `- chrome.bluetoothSocket - classic bluetooth connections

[rpaquay, 2014-04-22 15:47:55]

lgtm with nits.

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.cc
(right):

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
nit: Copyright 2014

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h
(right):

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
nit: Copyright 2014

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
File chrome/common/extensions/api/bluetooth_socket.idl (right):

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
nit: Copyright 2014

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:68: long resultCode;
Maybe we should use a custom enum for the bluetooth API, with a few entries only
(Ok, Disconnected, SystemError) as we did with chrome.serial.

We decided to use return code for TCP sockets, because they come from the net::
namespace, which normalizes them across platforms (all of them use some form of
posix-like "socket" api under the hood).

For Bluetooth, the OSX implementation is very different (it uses IOBluetoothXxx
functions) than Windows/ChromeOS, so I think it will be a challenge to normalize
error codes.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:131: // functions from the
<code>chrome.sockets.tcp</code> namespace. Note the
chrome.bluetoothSocket

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:244: // <code>resume</code>
method is called.
<code>setPaused(false)</code>

[not at google - send to devlin, 2014-04-22 17:26:59]

you've added all the right files and made the right changes. I didn't look at
the IDL content, did that get reviewed somewhere?

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h
(right):

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h:14: class
BluetoothSocketCreateFunction
make sure you run git cl format before submitting this.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
File chrome/common/extensions/api/bluetooth_socket.idl (right):

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:7: namespace bluetoothSocket {
is there an API proposal that encompasses this API?

[armansito, 2014-04-22 20:13:04]

lgtm with one nit.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
File chrome/common/extensions/api/bluetooth_socket.idl (right):

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:96: // mode data, or whether
connection requests on a listening socket are
nit: s/mode/more ?

[miket_OOO, 2014-04-22 20:18:16]

LGTM, please resolve kalman's questions

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
File chrome/common/extensions/api/bluetooth_socket.idl (right):

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:230: // depends on the
Operating System Host Subsystem.
Unless "Operating System Host Subsystem" is a term of art, it shouldn't be
capitalized. Otherwise it's confusing because people will look for a definition,
and won't find it. (this one and other occurrences in this file).

[keybuk, 2014-04-24 11:46:45]

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.cc
(right):

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2014/04/22 15:47:55, rpaquay wrote:
> nit: Copyright 2014

Done.

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h
(right):

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2014/04/22 15:47:55, rpaquay wrote:
> nit: Copyright 2014

Done.

https://codereview.chromium.org/246883003/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h:14: class
BluetoothSocketCreateFunction
On 2014/04/22 17:27:05, kalman wrote:
> make sure you run git cl format before submitting this.

Done.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
File chrome/common/extensions/api/bluetooth_socket.idl (right):

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/04/22 15:47:55, rpaquay wrote:
> nit: Copyright 2014

Done.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:7: namespace bluetoothSocket {
On 2014/04/22 17:27:05, kalman wrote:
> is there an API proposal that encompasses this API?

I wrote this to outline the changes:
https://docs.google.com/a/google.com/document/d/1NkO5_s_loaAv4sExBtZ1XE3z54ek...

For the most part it's just moving things from chrome.bluetooth to
chrome.bluetoothSocket and making them even more consistent with
chrome.sockets.*

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:68: long resultCode;
Oops, yes!

I was copying from both the existing idl and the sockets ones to make sure I got
consistency - looks like I copied the wrong thing here - I hadn't intended to
change that!

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:96: // mode data, or whether
connection requests on a listening socket are
On 2014/04/22 20:13:04, armansito wrote:
> nit: s/mode/more ?

Done.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:131: // functions from the
<code>chrome.sockets.tcp</code> namespace. Note the
On 2014/04/22 15:47:55, rpaquay wrote:
> chrome.bluetoothSocket

Done.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:230: // depends on the
Operating System Host Subsystem.
On 2014/04/22 20:18:17, miket wrote:
> Unless "Operating System Host Subsystem" is a term of art, it shouldn't be
> capitalized. Otherwise it's confusing because people will look for a
definition,
> and won't find it. (this one and other occurrences in this file).

Done.

https://codereview.chromium.org/246883003/diff/10001/chrome/common/extensions...
chrome/common/extensions/api/bluetooth_socket.idl:244: // <code>resume</code>
method is called.
On 2014/04/22 15:47:55, rpaquay wrote:
> <code>setPaused(false)</code>

Done.

[not at google - send to devlin, 2014-04-25 16:43:38]

lgtm

[keybuk, 2014-04-25 16:45:55]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-04-25 22:15:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/246883003/50001

[Ilya Sherman, 2014-04-25 22:59:23]

histograms lgtm, btw

[commit-bot: I haz the power, 2014-04-26 10:32:37]

Change committed as 266362