[HBD] Fix the misleading no-fallback placeholder message in BLOCK mode.

[HBD] Fix the misleading no-fallback placeholder message in BLOCK mode.

Previously, if the user had the BLOCK Content Setting (either from
Policy or just from user setting), the no-fallback placeholder for
HTML5 By Default would still say "Click to enable Flash".

This was misleading because that would not work. This updates the BLOCK
no-fallback placeholder to say "Flash is blocked" and "Flash is blocked
by enterprise policy" (if blocked by policy).

BUG=666774
Committed: https://crrev.com/e97656b8c9bb4fb2456673f4cd3d8eeb93a65bb8
Cr-Commit-Position: refs/heads/master@{#435289}

[tommycli, 2016-11-18 19:28:43]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 19:29:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-18 21:56:15]

[email protected] changed reviewers:
+ [email protected]

[tommycli, 2016-11-18 21:56:16]

georgesak: PTAL, I have manually tested and it seems to fix the issue.

[tommycli, 2016-11-18 22:18:01]

[email protected] changed reviewers:
+ [email protected]

[tommycli, 2016-11-18 22:18:02]

bauerb: PTAL chrome/browser/plugins thanks!

[commit-bot: I haz the power, 2016-11-18 22:21:25]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-11-18 22:21:26]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-11-21 11:58:52]

lgtm

[tommycli, 2016-11-22 17:04:53]

[email protected] changed reviewers:
+ [email protected], [email protected]

[tommycli, 2016-11-22 17:04:53]

thakis/dcheng: PTAL

thakis:
  chrome/browser/plugins/plugin_info_message_filter.cc
  chrome/renderer/chrome_content_renderer_client.cc
dcheng:
  chrome/common/render_messages.h

[Georges Khalil, 2016-11-22 18:26:50]

On 2016/11/22 17:04:53, tommycli wrote:
> thakis/dcheng: PTAL
> 
> thakis:
>   chrome/browser/plugins/plugin_info_message_filter.cc
>   chrome/renderer/chrome_content_renderer_client.cc
> dcheng:
>   chrome/common/render_messages.h

Just tested locally, works as intended. LGTM, thanks!

[dcheng, 2016-11-22 18:30:02]

ipc lgtm

[tommycli, 2016-11-23 19:20:34]

thakis: PTAL, thanks!

[tommycli, 2016-11-23 19:21:22]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:21:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 20:54:49]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-11-23 20:54:50]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-11-24 00:40:37]

lgtm stamp, but: no test, and nobody asked for one? :-(

https://codereview.chromium.org/2511263003/diff/1/chrome/common/render_messag...
File chrome/common/render_messages.h (right):

https://codereview.chromium.org/2511263003/diff/1/chrome/common/render_messag...
chrome/common/render_messages.h:40: enum class
ChromeViewHostMsg_GetPluginInfo_Status {
it'd be nice if these had comments about what they mean

[tommycli, 2016-11-28 19:28:21]

Patchset #2 (id:20001) has been deleted

[tommycli, 2016-11-28 20:21:26]

Thanks! I added a test in the last patchset. It required re-jiggering some
interfaces with PluginInfoMessageFilter for testability.

https://codereview.chromium.org/2511263003/diff/1/chrome/common/render_messag...
File chrome/common/render_messages.h (right):

https://codereview.chromium.org/2511263003/diff/1/chrome/common/render_messag...
chrome/common/render_messages.h:40: enum class
ChromeViewHostMsg_GetPluginInfo_Status {
On 2016/11/24 00:40:37, Nico wrote:
> it'd be nice if these had comments about what they mean

Done. I added some comments on the less obvious ones.

[tommycli, 2016-11-28 20:21:32]

The CQ bit was checked by [email protected] to run a CQ dry run

[tommycli, 2016-11-28 20:22:42]

thakis OR bauerb:

Do you guys mind checking the interface changes for PluginInfoMessageFilter
introduced in patchset 2?

I had to change it a bit to add a unit test for the behavior changes.

[commit-bot: I haz the power, 2016-11-28 20:23:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:28:25]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-11-28 20:28:26]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tommycli, 2016-11-28 22:31:59]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 22:34:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:31:14]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-11-29 00:31:15]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-11-29 16:46:57]

still lgtm, thanks for the test

https://codereview.chromium.org/2511263003/diff/60001/chrome/browser/plugins/...
File chrome/browser/plugins/plugin_info_message_filter.cc (right):

https://codereview.chromium.org/2511263003/diff/60001/chrome/browser/plugins/...
chrome/browser/plugins/plugin_info_message_filter.cc:472: enabled = true;
is this line covered by the test?

[tommycli, 2016-11-30 15:40:13]

thakis: No problem. This did indeed deserve a test.

https://codereview.chromium.org/2511263003/diff/60001/chrome/browser/plugins/...
File chrome/browser/plugins/plugin_info_message_filter.cc (right):

https://codereview.chromium.org/2511263003/diff/60001/chrome/browser/plugins/...
chrome/browser/plugins/plugin_info_message_filter.cc:472: enabled = true;
On 2016/11/29 16:46:57, Nico wrote:
> is this line covered by the test?

Yes, Line 254 of the unit test covers this condition. Thanks!

[tommycli, 2016-11-30 15:40:18]

The CQ bit was checked by [email protected]

[tommycli, 2016-11-30 15:40:18]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/2511263003/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2016-11-30 15:40:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 16:43:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480520418026170,
"parent_rev": "02b39f9134aef8b545d9261d174b59e617ff93f9", "commit_rev":
"2a6cb2d8046cb553e3853df51e19909fe6dee9a2"}

[commit-bot: I haz the power, 2016-11-30 16:43:35]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-30 16:47:37]

Description was changed from

==========
[HBD] Fix the misleading no-fallback placeholder message in BLOCK mode.

Previously, if the user had the BLOCK Content Setting (either from
Policy or just from user setting), the no-fallback placeholder for
HTML5 By Default would still say "Click to enable Flash".

This was misleading because that would not work. This updates the BLOCK
no-fallback placeholder to say "Flash is blocked" and "Flash is blocked
by enterprise policy" (if blocked by policy).

BUG=666774
==========

to

==========
[HBD] Fix the misleading no-fallback placeholder message in BLOCK mode.

Previously, if the user had the BLOCK Content Setting (either from
Policy or just from user setting), the no-fallback placeholder for
HTML5 By Default would still say "Click to enable Flash".

This was misleading because that would not work. This updates the BLOCK
no-fallback placeholder to say "Flash is blocked" and "Flash is blocked
by enterprise policy" (if blocked by policy).

BUG=666774

Committed: https://crrev.com/e97656b8c9bb4fb2456673f4cd3d8eeb93a65bb8
Cr-Commit-Position: refs/heads/master@{#435289}
==========

[commit-bot: I haz the power, 2016-11-30 16:47:39]

Patchset 3 (id:??) landed as
https://crrev.com/e97656b8c9bb4fb2456673f4cd3d8eeb93a65bb8
Cr-Commit-Position: refs/heads/master@{#435289}