Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2523723002: Update display::Display::kInvalidDisplayID constant. (Closed)

Created:
4 years ago by kylechar
Modified:
4 years ago
Reviewers:
stevenjb, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, sadrul, mlamouri+watch-screen-orientation_chromium.org, rjkroege, jam, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update display::Display::kInvalidDisplayID constant. The constant was moved to ui/display/types/display_constants.h and is now just display::kInvalidDisplayId. Update all references and delete the old constant. BUG=667344 [email protected] Committed: https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab Cr-Commit-Position: refs/heads/master@{#434043}

Patch Set 1 #

Patch Set 2 : Fix includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -94 lines) Patch
M ash/common/wm/window_positioning_utils.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_color_manager_chromeos.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ash/display/screen_ash.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ash/display/unified_mouse_warp_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 11 chunks +13 lines, -13 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/mus/property_util.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/root_window_settings.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/chromeos/screen_layout_observer.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/touch/touch_transformer_controller.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 1 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 1 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 10 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M services/ui/display/platform_screen_ozone.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M services/ui/display/platform_screen_ozone.cc View 1 5 chunks +4 lines, -6 lines 0 comments Download
M services/ui/public/cpp/window.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/platform_display_init_params.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/user_display_manager.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/window_tree.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ui/display/display.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
kylechar
4 years ago (2016-11-22 14:32:19 UTC) #2
sky
LGTM
4 years ago (2016-11-22 20:18:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523723002/20001
4 years ago (2016-11-23 00:19:08 UTC) #9
kylechar
+stevenjb for chrome/browser/ui/webui/options/*
4 years ago (2016-11-23 00:42:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 00:51:54 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-23 00:53:40 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc319224de8c68b2584e3bcc99d0b309dd630aab
Cr-Commit-Position: refs/heads/master@{#434043}

Powered by Google App Engine
This is Rietveld 408576698