Inline sign in flow with gaia auth extension

Inline sign in flow with gaia auth extension

Design doc at https://docs.google.com/a/google.com/document/d/1L0gcqZEZ0lWL0PgqO6uPyecuxJdTvzZpps2zRly_wTg/edit#heading=h.5cwdwtkutcuo

BUG=302037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226569

[guohui, 2013-09-30 22:28:29]

Hey Xiyuan & Roger,

could you please take a look the CL? It modifies the gaia auth extension for the
inline sign in flow.

Thanks,

Hui

[xiyuan, 2013-09-30 23:12:33]

LGTM

Glad to see webview works inside an extension. We probably should all switch to
it.

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/extensions...
File chrome/browser/extensions/scoped_gaia_auth_extension.cc (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/extensions...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:51: #endif  //
OS_CHROMEOS
nit: get rid of "// OS_CHROMEOS"

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:97: window.parent.postMessage(msg,
this.parentPage_);
I assume this is needed because <webview> case the success.html's postMessage
does not work. Please add a comment.

https://codereview.chromium.org/25347002/diff/20001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:623: const char kEnableInlineSignin[]      =
"enable-inline-signin";
nit: align '=' with other lines.

[Roger Tawa OOO till Jul 10th, 2013-10-01 00:28:49]

Looks good.  Some drive-by comments.

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/inline_injected.js (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:7: * Prototype Only.
Please add some more docs on exactly what is happening in this file, like for
example expected sequence of events.

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:39: CONTINUE_URL:
Authenticator.THIS_EXTENSION_ORIGIN + 'success.html',
Is there a missing '/' between the origin and the page name?

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth_host/gaia_auth_host.js (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth_host/gaia_auth_host.js:80: */
Add comment that this must match the c++ code.

[guohui, 2013-10-01 12:11:46]

+sky, owner review for

chrome\browser\browser_resources.grd
chrome\browser\extensions\scoped_gaia_auth_extension.cc

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/extensions...
File chrome/browser/extensions/scoped_gaia_auth_extension.cc (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/extensions...
chrome/browser/extensions/scoped_gaia_auth_extension.cc:51: #endif  //
OS_CHROMEOS
On 2013/09/30 23:12:34, xiyuan wrote:
> nit: get rid of "// OS_CHROMEOS"

Done.

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/inline_injected.js (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:7: * Prototype Only.
On 2013/10/01 00:28:49, Roger Tawa wrote:
> Please add some more docs on exactly what is happening in this file, like for
> example expected sequence of events.

Done.

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:7: * Prototype Only.
On 2013/10/01 00:28:49, Roger Tawa wrote:
> Please add some more docs on exactly what is happening in this file, like for
> example expected sequence of events.

Done.

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:39: CONTINUE_URL:
Authenticator.THIS_EXTENSION_ORIGIN + 'success.html',
On 2013/10/01 00:28:49, Roger Tawa wrote:
> Is there a missing '/' between the origin and the page name?

Thanks for spotting this!

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:97: window.parent.postMessage(msg,
this.parentPage_);
On 2013/09/30 23:12:34, xiyuan wrote:
> I assume this is needed because <webview> case the success.html's postMessage
> does not work. Please add a comment.

Done.

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth_host/gaia_auth_host.js (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth_host/gaia_auth_host.js:80: */
On 2013/10/01 00:28:49, Roger Tawa wrote:
> Add comment that this must match the c++ code.

Done.

https://codereview.chromium.org/25347002/diff/20001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/25347002/diff/20001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:623: const char kEnableInlineSignin[]      =
"enable-inline-signin";
On 2013/09/30 23:12:34, xiyuan wrote:
> nit: align '=' with other lines.

Done.

[sky, 2013-10-01 17:39:44]

LGTM

[commit-bot: I haz the power, 2013-10-01 17:50:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/25347002/31001

[commit-bot: I haz the power, 2013-10-01 18:06:43]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[guohui, 2013-10-01 18:26:29]

@dbeam, presubmit failed due to style violations in inline_injected.js. That JS
file will be injected into gaia, where $ is not necessarily defined, is there
any way to suppress the warning?

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/gaia_auth/inline_injected.js:
  line 15: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id')
  var gaiaLoginForm = document.getElementById('gaia_loginform');
                      ^^^^^^^^^^^^^^^^^^^^^^

[guohui, 2013-10-02 15:20:18]

nvm, fixed the style check in the latest patch.

[commit-bot: I haz the power, 2013-10-02 15:21:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/25347002/49001

[commit-bot: I haz the power, 2013-10-02 16:26:55]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-10-02 18:12:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/25347002/78001

[Dan Beam, 2013-10-02 18:33:41]

some observations

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/inline_injected.js (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:16: var $ = function(id) {
return document.getElementById(id); };
any reason why you're not simply including util.js?

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:21: console.log(e);
^ should this be in production code?

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:22: }
};

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:25: var onLoginSubmit =
function() {
function(e) {

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:28: return false;
nit: e.preventDefault();

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:39: return true;
^ remove

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:40: }
};

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:47: this.continueUrl_ =
params['continueUrl'] || this.CONTINUE_URL;
^ it is preferable to use .prop rather than ['prop']

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:80: 
/**
 * Description of what this method does.
 * @param {...} gaiaFrame ...
 * @private
 */

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:91: );
gaiaFrame.executeScript({file: 'inline_injected.js'}, function() {
  ...
});

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:93: } else if
(gaiaFrame.src.lastIndexOf(
} else if (gaiaFrame.src.lastIndexOf(this.continueUrl_, 0) == 0) {

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:98: gaiaFrame.style.display = 'none';
gaiaFrame.hidden = true;

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
File chrome/browser/resources/inline_login/inline_login.js (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/inline_login/inline_login.js:52: data.authMode, data,
onAuthCompleted);
fits in one line

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/ui/webui/i...
File chrome/browser/ui/webui/inline_login_ui.cc (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/ui/webui/i...
chrome/browser/ui/webui/inline_login_ui.cc:110: GaiaUrls * gaiaUrls =
GaiaUrls::GetInstance();
GaiaUrls*

[guohui, 2013-10-02 18:56:46]

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/inline_injected.js (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:16: var $ = function(id) {
return document.getElementById(id); };
On 2013/10/02 18:33:41, Dan Beam wrote:
> any reason why you're not simply including util.js?

because this file is injected into Gaia.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:21: console.log(e);
On 2013/10/02 18:33:41, Dan Beam wrote:
> ^ should this be in production code?

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:22: }
On 2013/10/02 18:33:41, Dan Beam wrote:
> };

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:25: var onLoginSubmit =
function() {
On 2013/10/02 18:33:41, Dan Beam wrote:
> function(e) {

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:28: return false;
On 2013/10/02 18:33:41, Dan Beam wrote:
> nit: e.preventDefault();

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:39: return true;
On 2013/10/02 18:33:41, Dan Beam wrote:
> ^ remove

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:40: }
On 2013/10/02 18:33:41, Dan Beam wrote:
> };

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:47: this.continueUrl_ =
params['continueUrl'] || this.CONTINUE_URL;
On 2013/10/02 18:33:41, Dan Beam wrote:
> ^ it is preferable to use .prop rather than ['prop']

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:80: 
On 2013/10/02 18:33:41, Dan Beam wrote:
> /**
>  * Description of what this method does.
>  * @param {...} gaiaFrame ...
>  * @private
>  */

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:91: );
On 2013/10/02 18:33:41, Dan Beam wrote:
> gaiaFrame.executeScript({file: 'inline_injected.js'}, function() {
>   ...
> });

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:93: } else if
(gaiaFrame.src.lastIndexOf(
On 2013/10/02 18:33:41, Dan Beam wrote:
> } else if (gaiaFrame.src.lastIndexOf(this.continueUrl_, 0) == 0) {

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/main.js:98: gaiaFrame.style.display = 'none';
On 2013/10/02 18:33:41, Dan Beam wrote:
> gaiaFrame.hidden = true;

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
File chrome/browser/resources/inline_login/inline_login.js (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/inline_login/inline_login.js:52: data.authMode, data,
onAuthCompleted);
On 2013/10/02 18:33:41, Dan Beam wrote:
> fits in one line

Done.

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/ui/webui/i...
File chrome/browser/ui/webui/inline_login_ui.cc (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/ui/webui/i...
chrome/browser/ui/webui/inline_login_ui.cc:110: GaiaUrls * gaiaUrls =
GaiaUrls::GetInstance();
On 2013/10/02 18:33:41, Dan Beam wrote:
> GaiaUrls*

Done.

[commit-bot: I haz the power, 2013-10-02 18:58:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/25347002/109001

[Dan Beam, 2013-10-02 19:09:05]

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
File chrome/browser/resources/gaia_auth/inline_injected.js (right):

https://codereview.chromium.org/25347002/diff/78001/chrome/browser/resources/...
chrome/browser/resources/gaia_auth/inline_injected.js:16: var $ = function(id) {
return document.getElementById(id); };
On 2013/10/02 18:56:46, guohui wrote:
> On 2013/10/02 18:33:41, Dan Beam wrote:
> > any reason why you're not simply including util.js?
> 
> because this file is injected into Gaia.

ah, I see.

[Dan Beam, 2013-10-02 19:09:55]

lgtm for cq

[commit-bot: I haz the power, 2013-10-02 20:41:57]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-10-02 20:53:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/25347002/109001

[commit-bot: I haz the power, 2013-10-02 21:34:18]

Change committed as 226569