Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 256873006: Remove scroll bars from animated-path-inside-transformed-html.xhtml (Closed)

Created:
6 years, 7 months ago by Noel Gordon
Modified:
6 years, 7 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, danakj, enne (OOO), jsbell
Visibility:
Public.

Description

Remove scroll bars from animated-path-inside-transformed-html.xhtml Modify the test to remove scrollbars so we don't test the scrollbar pixel output in this test: rotate the box by 10deg. BUG=367653, 367846 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172902

Patch Set 1 #

Patch Set 2 : Rotate the .box element by 10deg. #

Patch Set 3 : Avoid crbug.com/367846 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/svg/transforms/animated-path-inside-transformed-html.xhtml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Noel Gordon
6 years, 7 months ago (2014-04-28 08:37:53 UTC) #1
danakj
+enne
6 years, 7 months ago (2014-04-28 15:05:11 UTC) #2
Stephen Chennney
I would prefer changing the sizes in the test rather than adding overflow as part ...
6 years, 7 months ago (2014-04-28 17:28:38 UTC) #3
Noel Gordon
Ok removed rverflow:hidden. I found that rotating the box by 10deg instead of 20deg avoids ...
6 years, 7 months ago (2014-04-29 01:40:56 UTC) #4
Noel Gordon
Bots can't compile my patch ;)
6 years, 7 months ago (2014-04-29 02:24:54 UTC) #5
Noel Gordon
Ah the gardener beat me to it, http://crbug.com/367846 added new line to test expectations.
6 years, 7 months ago (2014-04-29 05:44:29 UTC) #6
Noel Gordon
New patch uploaded.
6 years, 7 months ago (2014-04-29 09:32:39 UTC) #7
Stephen Chennney
lgtm
6 years, 7 months ago (2014-04-29 14:32:54 UTC) #8
Noel Gordon
The CQ bit was checked by [email protected]
6 years, 7 months ago (2014-04-29 14:38:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/256873006/40001
6 years, 7 months ago (2014-04-29 14:39:05 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 03:48:08 UTC) #11
Message was sent while issue was closed.
Change committed as 172902

Powered by Google App Engine
This is Rietveld 408576698