Issue 25736004: Fixes use after free caused by delete in RootWindowController (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25736004: Fixes use after free caused by delete in RootWindowController (2) (Closed)

Created:
7 years, 2 months ago by sky

Modified:
7 years, 2 months ago

Reviewers:
oshima

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes use after free caused by delete in RootWindowController (2) RootWindowController::CloseChildWindows() was explicitly deleting windows. It should only do that for windows that are owned by the parent, otherwise the window should be removed. BUG=297028 TEST=covered by test now. [email protected] [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226524

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -5 lines)			Patch
M	ash/root_window_controller.cc	View		3 chunks	+12 lines, -3 lines	0 comments	Download
M	ash/root_window_controller_unittest.cc	View	1 2	2 chunks	+64 lines, -0 lines	0 comments	Download
M	ash/wm/frame_painter.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/aura/window.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

sky

Patchset 1 is the one you reviewed, 3 the fix. I needed to invoke Shutdown() ...

7 years, 2 months ago (2013-10-02 19:16:53 UTC) #2

sky

Committed patchset #3 manually as r226524 (presubmit successful).

7 years, 2 months ago (2013-10-02 19:25:27 UTC) #3

Message was sent while issue was closed.

lgtm