Issue 2582002: Makes LinkProgram fail if both a vertex and fragment shader...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2582002: Makes LinkProgram fail if both a vertex and fragment shader... (Closed)

Created:
10 years, 6 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Makes LinkProgram fail if both a vertex and fragment shader are not present. Desktop GL doesn't fail this case because the fixed function pipeline can be a substitute for either TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49073

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+197 lines, -31 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2	4 chunks	+13 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc	View	1 2	2 chunks	+25 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h	View	1 2	4 chunks	+17 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc	View	1 2	12 chunks	+65 lines, -27 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.h	View	1 2	4 chunks	+11 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View	1 2	2 chunks	+35 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager_unittest.cc	View	1 2	2 chunks	+31 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM